content-hub

Merge lp://staging/~ken-vandine/content-hub/dont_swallow_deactivate into lp://staging/content-hub

  1. dont_swallow_deactivate
  2. Merge into trunk
Proposed by Ken VanDine
Status: Merged
Approved by: Ken VanDine
Approved revision: 239
Merged at revision: 240
Proposed branch: lp://staging/~ken-vandine/content-hub/dont_swallow_deactivate
Merge into: lp://staging/content-hub
Diff against target: 29 lines (+5/-8)
1 file modified
src/com/ubuntu/content/hub.cpp (+5/-8)
To merge this branch: bzr merge lp://staging/~ken-vandine/content-hub/dont_swallow_deactivate
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Michael Sheldon (community) Approve
Sebastien Bacher Approve
Review via email: mp+268770@code.staging.launchpad.net

Commit message

Don't swallow QEvent::ApplicationDeactivate

Description of the change

Don't swallow QEvent::ApplicationDeactivate

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:238
http://jenkins.qa.ubuntu.com/job/content-hub-ci/275/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-vivid-amd64-ci/57
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-vivid-armhf-ci/57
        deb: http://jenkins.qa.ubuntu.com/job/content-hub-vivid-armhf-ci/57/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-vivid-i386-ci/57

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/content-hub-ci/275/rebuild

review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

works as it should, great bugfix!

review: Approve
lp://staging/~ken-vandine/content-hub/dont_swallow_deactivate updated
239. By Ken VanDine

warn when we don't call the handler

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Code looks good

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:239
http://jenkins.qa.ubuntu.com/job/content-hub-ci/276/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-vivid-amd64-ci/58
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-vivid-armhf-ci/58
        deb: http://jenkins.qa.ubuntu.com/job/content-hub-vivid-armhf-ci/58/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-vivid-i386-ci/58

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/content-hub-ci/276/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches