Merge lp://staging/~ken-vandine/content-hub/1_3 into lp://staging/content-hub

Proposed by Ken VanDine
Status: Merged
Approved by: Michael Sheldon
Approved revision: 251
Merged at revision: 249
Proposed branch: lp://staging/~ken-vandine/content-hub/1_3
Merge into: lp://staging/content-hub
Diff against target: 399 lines (+361/-1)
5 files modified
debian/changelog (+6/-0)
import/Ubuntu/Content/ContentPageHeader.qml (+97/-0)
import/Ubuntu/Content/ContentPeerPicker13.qml (+253/-0)
import/Ubuntu/Content/contenthubplugin.cpp (+2/-1)
import/Ubuntu/Content/qmldir (+3/-0)
To merge this branch: bzr merge lp://staging/~ken-vandine/content-hub/1_3
Reviewer Review Type Date Requested Status
Michael Sheldon (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+270560@code.staging.launchpad.net

Commit message

Added ContentPeerPicker13.qml for 1.3 imports

Description of the change

Added ContentPeerPicker13.qml for 1.3 imports

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
244. By Ken VanDine

merged trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
245. By Ken VanDine

Added ContentPageHeader (copied from webbrowser-app) to provide our own header

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
246. By Ken VanDine

Added a read-only property to ContentPeerPicker to expose the title

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
247. By Ken VanDine

dropped the title property added in the previous commit

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
248. By Ken VanDine

Updated for UbuntuShape deprecations

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/content-hub) on device or emulator?

 * Yes

If you changed the UI, was the change specified/approved by design?

 * No

If you changed UI labels, did you update the pot file?

 * No

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?

 * No

249. By Ken VanDine

merged trunk

250. By Ken VanDine

Major version bump

251. By Ken VanDine

removed hardcoded color

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?

 * Yes

Did CI run pass? If not, please explain why.

 * Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?

 * Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches