Online Accounts: Account plugins

Merge lp://staging/~ken-vandine/account-plugins/inline into lp://staging/account-plugins

  1. inline
  2. Merge into trunk
Proposed by Ken VanDine
Status: Superseded
Proposed branch: lp://staging/~ken-vandine/account-plugins/inline
Merge into: lp://staging/account-plugins
Diff against target: 506 lines (+420/-0)
17 files modified
.bzr-builddeb/default.conf (+2/-0)
debian/account-plugin-facebook.install (+7/-0)
debian/account-plugin-flickr.install (+5/-0)
debian/account-plugin-foursquare.install (+5/-0)
debian/account-plugin-google.install (+7/-0)
debian/account-plugin-icons.install (+14/-0)
debian/account-plugin-identica.install (+5/-0)
debian/account-plugin-sina.install (+4/-0)
debian/account-plugin-sohu.install (+4/-0)
debian/account-plugin-tools.install (+2/-0)
debian/account-plugin-twitter.install (+5/-0)
debian/account-plugin-windows-live.install (+5/-0)
debian/changelog (+201/-0)
debian/compat (+1/-0)
debian/control (+108/-0)
debian/copyright (+20/-0)
debian/rules (+25/-0)
To merge this branch: bzr merge lp://staging/~ken-vandine/account-plugins/inline
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Didier Roche-Tolomelli Pending
Review via email: mp+134491@code.staging.launchpad.net

This proposal supersedes a proposal from 2012-11-12.

This proposal has been superseded by a proposal from 2012-11-15.

Commit message

Merge packaging inline to trunk

Description of the change

Merge packaging inline to trunk

To post a comment you must log in.
Revision history for this message
David King (amigadave) wrote : Posted in a previous version of this proposal

I am not sure of the terms, but surely this exposes the API keys for the various online services, by placing them in the same branch?

Revision history for this message
Alberto Mardegan (mardy) wrote : Posted in a previous version of this proposal

This looks fine to me, but I'm a bit concerned about the application keys, which will now live in the same branch as the source code.
(though this won't be a big problem, once we allow applications specify their own keys)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:77
http://s-jenkins:8080/job/online-accounts-account-plugins-ci/14/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/online-accounts-account-plugins-ci/./label=quantal/14/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote : Posted in a previous version of this proposal

As discussed on Friday, looks good to me :)

Please coordinate with fginther to get it merged as he needs to make some magic in jenkins side.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:77
http://s-jenkins:8080/job/account-plugins-ci/1/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/account-plugins-ci/./build=pbuilder,distribution=quantal,flavor=amd64/1/console
    FAILURE: http://s-jenkins:8080/job/account-plugins-ci/./build=pbuilder,distribution=quantal,flavor=i386/1/console

review: Needs Fixing (continuous-integration)

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches