Print Indicator

Merge lp://staging/~kelemeng/indicator-printers/bug1279605 into lp://staging/indicator-printers/14.04

  1. bug1279605
  2. Merge into trunk.14.04
Proposed by Gabor Kelemen
Status: Merged
Approved by: Lars Karlitski
Approved revision: 66
Merged at revision: 66
Proposed branch: lp://staging/~kelemeng/indicator-printers/bug1279605
Merge into: lp://staging/indicator-printers/14.04
Diff against target: 52 lines (+20/-0)
2 files modified
configure.ac (+13/-0)
src/indicator-printers-service.c (+7/-0)
To merge this branch: bzr merge lp://staging/~kelemeng/indicator-printers/bug1279605
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Lars Karlitski (community) Approve
Review via email: mp+206073@code.staging.launchpad.net

Commit message

Add proper i18n support. Fixes LP:1279605

To post a comment you must log in.
Revision history for this message
Lars Karlitski (larsu) wrote :

Thanks a lot!

Any reason you didn't use AM_GLIB_DEFINE_LOCALEDIR in configure.ac?

Revision history for this message
Gabor Kelemen (kelemeng) wrote :

Uh, no, I didn't know about that, just copied from indicator-sound. Should I change it?

Revision history for this message
Lars Karlitski (larsu) wrote :

Nah, not important enough. Thanks again!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~kelemeng/indicator-printers/bug1279605/+merge/206073/+edit-commit-message

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches