Merge lp://staging/~kdub/mir/rm-depository-from-screencast into lp://staging/mir
Status: | Work in progress |
---|---|
Proposed branch: | lp://staging/~kdub/mir/rm-depository-from-screencast |
Merge into: | lp://staging/mir |
Diff against target: |
162 lines (+72/-11) 3 files modified
src/client/screencast_stream.cpp (+12/-9) src/client/screencast_stream.h (+3/-2) tests/unit-tests/client/test_screencast_stream.cpp (+57/-0) |
To merge this branch: | bzr merge lp://staging/~kdub/mir/rm-depository-from-screencast |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexandros Frantzis (community) | Needs Fixing | ||
Chris Halse Rogers | Approve | ||
Mir CI Bot | continuous-integration | Needs Fixing | |
Review via email: mp+298298@code.staging.launchpad.net |
Commit message
client: remove usage of BufferVault in the ScreencastStream. Disentangles ScreencastStream, preparing for BufferVault's removal once we're ready to remove that code.
This also reduces the client-side number of mapped buffers to just the current one, whereas before, we were keeping 3 around, and kicking out the oldest one as new ones arrived.
Also add a bonus test where I noticed that a wait handle could have been left hanging if an exception threw around buffer creation.
Description of the change
client: remove usage of BufferVault in the ScreencastStream. Disentangles ScreencastStream, preparing for BufferVault's removal once we're ready to remove that code.
This also reduces the client-side number of mapped buffers to just the current one, whereas before, we were keeping 3 around, and kicking out the oldest one as new ones arrived.
Also add a bonus test where I noticed that a wait handle could have been left hanging if an exception threw around buffer creation.
Unmerged revisions
- 3534. By Kevin DuBois
-
merge in mir
- 3533. By Kevin DuBois
-
merge in mir
- 3532. By Kevin DuBois
-
test to avoid hanging to pass
FAILED: Continuous integration, rev:3534 /mir-jenkins. ubuntu. com/job/ mir-ci/ 1195/ /mir-jenkins. ubuntu. com/job/ build-mir/ 1356/console /mir-jenkins. ubuntu. com/job/ build-0- fetch/1407 /mir-jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= vivid+overlay/ 1398 /mir-jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= xenial/ 1398 /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= clang,platform= mesa,release= vivid+overlay/ 1370/console /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= gcc,platform= mesa,release= xenial/ 1370/console /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= cross-armhf, compiler= gcc,platform= android, release= vivid+overlay/ 1370/console /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= cross-armhf, compiler= gcc,platform= android, release= vivid+overlay/ 1370/artifact/ output/ *zip*/output. zip /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= i386,compiler= gcc,platform= android, release= vivid+overlay/ 1370/console /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= i386,compiler= gcc,platform= mesa,release= xenial/ 1370/console
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
deb: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild: /mir-jenkins. ubuntu. com/job/ mir-ci/ 1195/rebuild
https:/