Merge lp://staging/~kdub/mir/fix-ci into lp://staging/mir
Status: | Merged |
---|---|
Merged at revision: | 3591 |
Proposed branch: | lp://staging/~kdub/mir/fix-ci |
Merge into: | lp://staging/mir |
Diff against target: |
39 lines (+12/-1) 3 files modified
cmake/MirCommon.cmake (+1/-0) tests/privileged-tests/test_input_events.cpp (+1/-1) tools/valgrind_suppressions_libhybris (+10/-0) |
To merge this branch: | bzr merge lp://staging/~kdub/mir/fix-ci |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel van Vugt | Approve | ||
Mir CI Bot | continuous-integration | Needs Fixing | |
Cemil Azizoglu (community) | Approve | ||
Brandon Schaefer (community) | Approve | ||
Review via email: mp+300063@code.staging.launchpad.net |
Description of the change
Suppress memory leak in libhybris generated when probing android platforms.
also disable a failing mir_privileged_test until proper fix can be found. (LP: #1603145)
Fixes: LP: #1602199
The suppression is too broad, really. It will suppress all leaks in platform probing.
This is due to valgrind not really being able to figure out that code from libhybris is in the stack when the leak occurs. eg:
==13834== at 0x4C2DB8F: malloc (in /usr/lib/
==13834== by 0xB56CE27: doc src
==13834== by 0xB56CFFB: doc src
==13834== by 0xB56C677: doc src
==13834== by 0xB77F59A: doc src
==13834== by 0xB77F97C: doc src
==13834== by 0xB77FC5E: doc src
==13834== by 0xB3697A8: doc src
==13834== by 0xAEB9029: std::_Head_
==13834== by 0x70469F: mir::graphics:
not sure why its saying 'doc src' in the leak report. If anyone has ideas about a better suppression match, we could take those.
just testing theories at the moment.