Mir

Merge lp://staging/~kdub/mir/fix-1554635 into lp://staging/mir

Proposed by Kevin DuBois
Status: Merged
Approved by: Cemil Azizoglu
Approved revision: no longer in the source branch.
Merged at revision: 3407
Proposed branch: lp://staging/~kdub/mir/fix-1554635
Merge into: lp://staging/mir
Diff against target: 49 lines (+15/-3)
2 files modified
src/platforms/android/common/egl_sync_fence.cpp (+13/-1)
tests/unit-tests/graphics/android/test_egl_sync_fence.cpp (+2/-2)
To merge this branch: bzr merge lp://staging/~kdub/mir/fix-1554635
Reviewer Review Type Date Requested Status
Mir CI Bot continuous-integration Approve
Cemil Azizoglu (community) Approve
Brandon Schaefer (community) Approve
Alberto Aguirre (community) Approve
Review via email: mp+289419@code.staging.launchpad.net

Commit message

android: Just log the error when an eglSyncFence installation failure occurs. Apparently this happens on turbo during certain scenarios.

A bit of further digging might yield another solution, but this at least averts u8 from crashing, and is a transient problem on that device.

fixes: LP: #1554635

Description of the change

android: Just log the error when an eglSyncFence installation failure occurs. Apparently this happens on turbo during certain scenarios.

A bit of further digging might yield another solution, but this at least averts u8 from crashing, and is a transient problem on that device.

fixes: LP: #1554635

To post a comment you must log in.
Revision history for this message
Alberto Aguirre (albaguirre) wrote :

Ok as a workaround.

review: Approve
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

LGTM

review: Approve
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

Ok

review: Approve
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:3397
https://mir-jenkins.ubuntu.com/job/mir-ci/615/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/524
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/554
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/546
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/546
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/534
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/534/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/534
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/534/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/534
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/534/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/534
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/534/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/534
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/534/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/615/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches