content-hub

Merge lp://staging/~kdub/content-hub/mir-deprecations into lp://staging/content-hub

Proposed by Kevin DuBois on 2017-02-20

Status:	Merged
Approved by:	Ken VanDine on 2017-04-04
Approved revision:	326
Merged at revision:	336
Proposed branch:	lp://staging/~kdub/content-hub/mir-deprecations
Merge into:	lp://staging/content-hub
Diff against target:	95 lines (+12/-25) 4 files modified debian/control (+1/-1) examples/pasteboard/copy.cpp (+3/-3) examples/pasteboard/paste.cpp (+3/-3) src/com/ubuntu/content/detail/mir-helper.cpp (+5/-18)
To merge this branch:	bzr merge lp://staging/~kdub/content-hub/mir-deprecations
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Ken VanDine		2017-02-20	Approve on 2017-04-04
Review via email: mp+317770@code.staging.launchpad.net

mir-helper: transition deprecated functions from mir 0.26 to the non-deprecated alternatives.

mir-helper: transition deprecated functions from mir 0.26 to the non-deprecated alternatives.

Revision history for this message

Alberto Mardegan (mardy) wrote on 2017-02-22:

Thanks Kevin! For the record, I applied the same changes to Online Accounts (minus cosmetic changes):

Revision history for this message

Kevin DuBois (kdub) wrote on 2017-03-06:

> Thanks Kevin! For the record, I applied the same changes to Online Accounts
> (minus cosmetic changes):
>
> https://code.launchpad.net/~mardy/ubuntu-system-settings-online-accounts/mir-
> deprecations/+merge/317949

Cool, could you suggest a way to test the change? I don't think its covered in the unit tests.

Revision history for this message

Ken VanDine (ken-vandine) wrote on 2017-03-07:

Please remove the changelog entry. Otherwise it looks good. You can run through the manual test plan at https://wiki.ubuntu.com/Process/Merges/TestPlan/content-hub

review: Needs Fixing

Revision history for this message

Ken VanDine (ken-vandine) wrote on 2017-03-07:

Also please update the build depends version

review: Needs Fixing

Revision history for this message

Kevin DuBois (kdub) wrote on 2017-04-04:

> Please remove the changelog entry. Otherwise it looks good. You can run
> through the manual test plan at
> https://wiki.ubuntu.com/Process/Merges/TestPlan/content-hub

There's a fair amount in the test plan that I don't quite understand, but can test best I can...
eg, not sure what "peers" are in this context.

Revision history for this message

Ken VanDine (ken-vandine) wrote on 2017-04-04:

Thanks, looks great!

review: Approve