Merge lp://staging/~karni/ubuntuone-files-java-library/volume-operations into lp://staging/ubuntuone-files-java-library/0.x

Proposed by Michał Karnicki
Status: Merged
Merge reported by: Michał Karnicki
Merged at revision: not available
Proposed branch: lp://staging/~karni/ubuntuone-files-java-library/volume-operations
Merge into: lp://staging/ubuntuone-files-java-library/0.x
Diff against target: 1846 lines (+1172/-562)
10 files modified
main/src/com/ubuntu/one/api/files/UbuntuOneFileAPI.java (+74/-0)
main/src/com/ubuntu/one/api/files/util/ResponseHeader.java (+1/-1)
main/src/com/ubuntuone/api/files/client/ResourceClient.java (+11/-1)
test/src/com/ubuntu/one/api/files/CreateVolumeTest.java (+269/-0)
test/src/com/ubuntu/one/api/files/DeleteVolumeTest.java (+248/-0)
test/src/com/ubuntu/one/api/files/GetUserTest.java (+248/-0)
test/src/com/ubuntu/one/api/files/GetVolumesTest.java (+307/-0)
test/src/com/ubuntu/one/api/files/U1UserTest.java (+0/-250)
test/src/com/ubuntu/one/api/files/U1VolumeTest.java (+0/-306)
test/src/com/ubuntu/one/api/files/util/Util.java (+14/-4)
To merge this branch: bzr merge lp://staging/~karni/ubuntuone-files-java-library/volume-operations
Reviewer Review Type Date Requested Status
Michał Karnicki (community) Approve
Chad Miller Pending
Review via email: mp+92835@code.staging.launchpad.net

Description of the change

Add create and delete volume, with tests.

To post a comment you must log in.
Revision history for this message
Chad Miller (cmiller) wrote :

Some inconsistent spacing, e.g., diff line 60.

Do you need this in setUp()?

753 + corruptHttpResponse = Util.buildOkResponse();
754 + corruptHttpResponse.setEntity(
755 + new StringEntity("{\"corrupt json", "UTF-8"));

6. By Michał Karnicki

Move corrupt response out of text fixture.

Revision history for this message
Michał Karnicki (karni) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: