Merge lp://staging/~karni/ubuntuone-files-java-library/more-features into lp://staging/ubuntuone-files-java-library/0.x

Proposed by Michał Karnicki
Status: Merged
Approved by: Chad Miller
Approved revision: 18
Merged at revision: 18
Proposed branch: lp://staging/~karni/ubuntuone-files-java-library/more-features
Merge into: lp://staging/ubuntuone-files-java-library/0.x
Prerequisite: lp://staging/~karni/ubuntuone-files-java-library/volume-operations
Diff against target: 4633 lines (+3026/-761)
35 files modified
.classpath (+6/-0)
main/src/com/ubuntu/one/api/files/U1FileAPI.java (+843/-0)
main/src/com/ubuntu/one/api/files/UbuntuOneFileAPI.java (+0/-295)
main/src/com/ubuntu/one/api/files/client/BaseClient.java (+84/-0)
main/src/com/ubuntu/one/api/files/client/ContentClient.java (+89/-0)
main/src/com/ubuntu/one/api/files/client/ResourceClient.java (+70/-0)
main/src/com/ubuntu/one/api/files/example/SimpleExample.java (+519/-0)
main/src/com/ubuntu/one/api/files/json/U1CustomNodeJson.java (+76/-0)
main/src/com/ubuntu/one/api/files/json/U1NodeJson.java (+203/-0)
main/src/com/ubuntu/one/api/files/json/U1UserJson.java (+8/-4)
main/src/com/ubuntu/one/api/files/json/U1VolumeJson.java (+16/-10)
main/src/com/ubuntu/one/api/files/util/Callback.java (+98/-8)
main/src/com/ubuntu/one/api/files/util/CancelTrigger.java (+45/-0)
main/src/com/ubuntu/one/api/files/util/HashUtils.java (+105/-0)
main/src/com/ubuntu/one/api/files/util/HttpUriRequestFactory.java (+27/-0)
main/src/com/ubuntu/one/api/files/util/ProgressListener.java (+118/-0)
main/src/com/ubuntu/one/api/files/util/RequestListener.java (+18/-0)
main/src/com/ubuntuone/api/files/client/BaseClient.java (+0/-70)
main/src/com/ubuntuone/api/files/client/ContentClient.java (+0/-15)
main/src/com/ubuntuone/api/files/client/ResourceClient.java (+0/-48)
test/src/com/ubuntu/one/api/files/CreateVolumeTest.java (+32/-30)
test/src/com/ubuntu/one/api/files/DeleteVolumeTest.java (+36/-35)
test/src/com/ubuntu/one/api/files/GetUserTest.java (+27/-22)
test/src/com/ubuntu/one/api/files/GetVolumesTest.java (+27/-22)
test/src/com/ubuntu/one/api/files/json/U1NodeJsonTest.java (+103/-0)
test/src/com/ubuntu/one/api/files/json/U1UserJsonTest.java (+36/-0)
test/src/com/ubuntu/one/api/files/json/U1VolumeJsonTest.java (+38/-0)
test/src/com/ubuntu/one/api/files/util/U1FileBuilder.java (+0/-158)
test/src/com/ubuntu/one/api/files/util/U1NodeBuilder.java (+268/-0)
test/src/com/ubuntu/one/test/util/DummyAuthorizer.java (+13/-0)
test/src/com/ubuntu/one/test/util/SameCauseExceptionMatcher.java (+0/-36)
test/src/com/ubuntu/one/test/util/SameCauseFailureMatcher.java (+35/-0)
test/src/com/ubuntu/one/test/util/SameHttpRequestMatcher.java (+8/-8)
test/src/com/ubuntu/one/test/util/SameHttpUriRequestMatcher.java (+43/-0)
test/src/com/ubuntu/one/test/util/SameStatusCodeFailureMatcher.java (+35/-0)
To merge this branch: bzr merge lp://staging/~karni/ubuntuone-files-java-library/more-features
Reviewer Review Type Date Requested Status
Chad Miller Pending
Review via email: mp+94371@code.staging.launchpad.net

Description of the change

This branch packs bigger chunk of the library implementation. Please refer to commit messages for break down.

To post a comment you must log in.
13. By Michał Karnicki

Consume response entity cleanly in deleteNode call.

14. By Michał Karnicki

Use interfaces for Up/DownloadRequestListeners.

15. By Michał Karnicki

Update test file paths.

16. By Michał Karnicki

Add content type parameter to uploads.

17. By Michał Karnicki

Consume response entity when deleting volume.
Utilize ubuntu-sso-java-client for authentication.

18. By Michał Karnicki

Reuse sso library authenticators.

Revision history for this message
Chad Miller (cmiller) wrote :

1714 + @Override
1715 + public void onCancel() {
1716 + }
1717 +
1718 + @Override
1719 + public void onFinish() {
1720 + print("");
1721 + }

These tell me that you should have implementations that do nothing, and which the user may optionally override.

Revision history for this message
Michał Karnicki (karni) wrote :

Totally agreed. These dummy implementations would further increase the size of the diff, so I'd like to keep that for another branch.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: