Merge lp://staging/~karni/ubuntuone-android-files/notification-progressbar into lp://staging/ubuntuone-android-files

Proposed by Michał Karnicki
Status: Merged
Merged at revision: 194
Proposed branch: lp://staging/~karni/ubuntuone-android-files/notification-progressbar
Merge into: lp://staging/ubuntuone-android-files
Diff against target: 546 lines (+274/-110)
4 files modified
res/layout/notification_progress.xml (+67/-0)
src/com/ubuntuone/android/files/service/UpDownService.java (+161/-109)
src/com/ubuntuone/android/files/service/UpDownServiceHelper.java (+4/-1)
src/com/ubuntuone/android/files/widget/TextProgressBar.java (+42/-0)
To merge this branch: bzr merge lp://staging/~karni/ubuntuone-android-files/notification-progressbar
Reviewer Review Type Date Requested Status
Michał Karnicki (community) Approve
Chad Miller Pending
Review via email: mp+71563@code.staging.launchpad.net

Description of the change

This branch adds progress bars to upload/download notification.

To post a comment you must log in.
Revision history for this message
Michał Karnicki (karni) wrote :

For reviewers information - TextProgressBar class is not used yet. I've added it, but had issues with Android throwing ClassNotFoundException when using TextProgressBar in the layout and source. The ProgressBar used in the notification currently contains no text overlay.

Revision history for this message
Michał Karnicki (karni) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: