Merge lp://staging/~karni/ubuntuone-android-files/fix-hc-notification into lp://staging/ubuntuone-android-files
Proposed by
Michał Karnicki
| Status: | Merged |
|---|---|
| Approved by: | Chad Miller |
| Approved revision: | 218 |
| Merged at revision: | 218 |
| Proposed branch: | lp://staging/~karni/ubuntuone-android-files/fix-hc-notification |
| Merge into: | lp://staging/ubuntuone-android-files |
| Diff against target: |
140 lines (+50/-12) 5 files modified
res/layout/notification_progress.xml (+12/-10) res/values-v11/themes.xml (+14/-0) res/values/themes.xml (+13/-0) src/com/ubuntuone/android/files/service/TransferExecutor.java (+5/-2) src/com/ubuntuone/android/files/util/VersionUtilities.java (+6/-0) |
| To merge this branch: | bzr merge lp://staging/~karni/ubuntuone-android-files/fix-hc-notification |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Chad Miller (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This branch fixes:
- reappearing notification
- notification text color
Both issues relate to Honeycomb+
To post a comment you must log in.
Revision history for this message
| Chad Miller (cmiller) wrote | # |
Revision history for this message
| Chad Miller (cmiller) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The notification-text seems strange. I'd guess either there's a bug in Honeycomb, our style implementation is incomplete, or we're overriding the style wrongly in code.