Merge lp://staging/~karni/ubuntuone-android-files/fix-crashreport-file-uri into lp://staging/ubuntuone-android-files
Proposed by
Michał Karnicki
| Status: | Merged |
|---|---|
| Approved by: | Chad Miller |
| Approved revision: | 177 |
| Merged at revision: | 177 |
| Proposed branch: | lp://staging/~karni/ubuntuone-android-files/fix-crashreport-file-uri |
| Merge into: | lp://staging/ubuntuone-android-files |
| Diff against target: |
50 lines (+23/-6) 2 files modified
src/com/ubuntuone/android/files/provider/MetaUtilities.java (+9/-4) src/com/ubuntuone/android/files/service/UpDownServiceHelper.java (+14/-2) |
| To merge this branch: | bzr merge lp://staging/~karni/ubuntuone-android-files/fix-crashreport-file-uri |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Chad Miller (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Sample contents of crash report errors:
- file://
- file://
This branch:
1) avoids prepending file scheme, if it is already present.
2) verifies if file:// URI is valid, catches exception, and returns false in such case. If the entry was a failed upload, it is removed due to invalid / malformed URI.
To post a comment you must log in.
Revision history for this message
| Chad Miller (cmiller) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
