Merge lp://staging/~kangol/openobject-server/6.0-context-report into lp://staging/openobject-server/6.0
Proposed by
Christophe Simonis (OpenERP)
Status: | Needs review |
---|---|
Proposed branch: | lp://staging/~kangol/openobject-server/6.0-context-report |
Merge into: | lp://staging/openobject-server/6.0 |
Diff against target: |
75 lines (+7/-7) 5 files modified
bin/report/custom.py (+2/-2) bin/report/interface.py (+1/-1) bin/report/printscreen/ps_form.py (+1/-1) bin/report/printscreen/ps_list.py (+1/-1) bin/report/render/rml2pdf/trml2pdf.py (+2/-2) |
To merge this branch: | bzr merge lp://staging/~kangol/openobject-server/6.0-context-report |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Naresh(OpenERP) (community) | Needs Fixing | ||
Review via email: mp+61936@code.staging.launchpad.net |
To post a comment you must log in.
Unmerged revisions
- 3433. By Christophe Simonis (OpenERP)
-
[FIX] report: correct context cleaning when render RML
- 3432. By Christophe Simonis (OpenERP)
-
[FIX] report: pass context when render RML
Hello Christophe,
if we talk about passing the missing context the merge proposal seems Good ! :)
But at the end you removed the 'internal_header' from the localcontext, doing so will not print the page number formatting on right top corner (page 1 out of 10) which is supposed to be printed when internal header is selected. The condition is needed here
if self.localcontext and not self.localconte xt.get( 'internal_ header' ,False) : localcontext. pop('internal_ header' , None)
self.
Thanks,