Merge lp://staging/~kamstrup/unity-lens-applications/ratings-query into lp://staging/unity-lens-applications
Proposed by
Mikkel Kamstrup Erlandsen
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Merged at revision: | 233 | ||||||||
Proposed branch: | lp://staging/~kamstrup/unity-lens-applications/ratings-query | ||||||||
Merge into: | lp://staging/unity-lens-applications | ||||||||
Diff against target: | 0 lines | ||||||||
To merge this branch: | bzr merge lp://staging/~kamstrup/unity-lens-applications/ratings-query | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michal Hruby (community) | Approve | ||
Review via email: mp+76566@code.staging.launchpad.net |
Description of the change
Implement support for the Ratings filter.
We share a Berkely DB with the Software Center with the Ratings data in. The db is in single-
Also adds a configure check for xapian.h now that we are here.
ALMOST forgot to add: This branch relies on the DB generated by this branch lp:~mvo/software-center/review-stats-as-dbm-for-unity-with-best-regards to make filtering work. But it's a good test to try without it, as we should have graceful fallback.
To post a comment you must log in.
Looks nice! I didn't check out the SC branch, so didn't test it fully, but at least I tested the db-not-there case.
Just a couple minor things:
455 + public Database () throws GLib.IOError;
you're throwing GFileError, so either "throws FileError" or just "throws Error".
180 + ratings.query (pkginfo. package_ name, out result);
perhaps it'd better to enclose it in an "if" considering it returns bool
362 + out_result->pkgname = pkgname;
a bit dangerous, but as long as it's not really used...
But all in all, approve! :)