Merge lp://staging/~kamstrup/bamf-qt/fixes-for-jhbuild into lp://staging/bamf-qt

Proposed by Mikkel Kamstrup Erlandsen
Status: Merged
Approved by: Gerry Boland
Approved revision: 392
Merged at revision: 392
Proposed branch: lp://staging/~kamstrup/bamf-qt/fixes-for-jhbuild
Merge into: lp://staging/bamf-qt
Diff against target: 25 lines (+10/-3)
1 file modified
CMakeLists.txt (+10/-3)
To merge this branch: bzr merge lp://staging/~kamstrup/bamf-qt/fixes-for-jhbuild
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
Review via email: mp+85614@code.staging.launchpad.net

Description of the change

Fix installation of libQtBamfQml.so into qt4/imports under jhbuild, by allowing one to override the directory by setting -DQT_IMPORTS_DIR=/my/dir on the cmake command line

I am working on adding the entire unity-2d stack to the lp:unity-jhbuild setup, and this fix is a requirement to get that working

To post a comment you must log in.
391. By Mikkel Kamstrup Erlandsen

Fix installation of libQtBamfQml.so into qt4/imports under jhbuild, by allowing one to override the directory by setting -DQT_IMPORTS_DIR on the cmake commend line

392. By Mikkel Kamstrup Erlandsen

Update comments on QT_IMPORTS_DIR and QT_INSTALL_IMPORTS usage

Revision history for this message
Gerry Boland (gerboland) wrote :

Works well, will accept.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches