LightDM GTK Greeter

Merge lp://staging/~kalgasnik/lightdm-gtk-greeter/post-2.0.0 into lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk

post-2.0.0
Merge into trunk

Proposed by Andrew P. on 2015-03-04

Status:

Merged

Merged at revision:

326

Proposed branch:

lp://staging/~kalgasnik/lightdm-gtk-greeter/post-2.0.0

Merge into:

lp://staging/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk

Diff against target:

1539 lines (+685/-278)

8 files modified

src/Makefile.am (+2/-0)
src/greeterbackground.c (+75/-39)
src/greeterbackground.h (+16/-3)
src/greeterconfiguration.c (+371/-0)
src/greeterconfiguration.h (+57/-0)
src/lightdm-gtk-greeter-fallback.css (+5/-5)
src/lightdm-gtk-greeter.c (+154/-229)
src/lightdm-gtk-greeter.glade (+5/-2)

To merge this branch:

bzr merge lp://staging/~kalgasnik/lightdm-gtk-greeter/post-2.0.0

Related bugs:

Bug #1410406: black screen after booting, 100% cpu usage	Undecided	Fix Released
Bug #1421587: Please support config in /usr/share/lightdm/lightdm.conf.d/ and /etc/lightdm/lightdm.conf.d/	Undecided	Fix Released
Bug #1426664: After booting to lightdm-gtk-greeter, get a white screen until I click a mouse button	Undecided	Fix Released
Bug #1449567: Cannot see login box on a locked screen	Undecided	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Sean Davis			Approve on 2015-04-26
Andrew P.			Pending
Review via email: mp+251694@code.staging.launchpad.net

Description of the change

1. Greeter can go to infinite loop at launch when used with two monitors in mirrored mode and active-monitor=#cursor

http://ubuntuforums.org/showthread.php?t=2268061
http://forum.ubuntuusers.de/topic/loginbildschirm-weis-erst-nach-rechtsklick-sic/
http://ubuntuforums.org/showthread.php?t=2267474
https://bugs.archlinux.org/task/43999

2. gtk_widget_reparent marked as deprecated in 3.14 but gtk_container_remove/add is not equal replacement if widget contains GtkPlug.
gtk_widget_reparent used in greeter to move screen_overlay from on monitor window to another.
Looks like remove/add leaves GtkPlug in invalid state.

http://i.imgur.com/E7BtTRx.png
http://i.imgur.com/dlvjay5.png

3. Sending "WM_TAKE_FOCUS" to active monitor window, "onboard" just doesn't work in xembed mode without it.

4. Greeter doesn't lose focus when monitors configuration changed.

5. Multiple configuration files. Order:
g_get_system_data_dirs():
.../lightdm/lightdm-gtk-greeter.conf.d/*.conf
.../lightdm/lightdm-gtk-greeter.conf
g_get_system_config_dirs():
.../lightdm/lightdm-gtk-greeter.conf.d/*.conf
.../lightdm/lightdm-gtk-greeter.conf
/etc/lightdm/lightdm-gtk-greeter.conf.d/*.conf
/etc/lightdm/lightdm-gtk-greeter.conf

Sample:
/usr/share/lightdm/lightdm-gtk-greeter.conf.d/a.conf
/etc/xdg/lightdm/lightdm-gtk-greeter.conf.d/1.conf
/etc/xdg/lightdm/lightdm-gtk-greeter.conf.d/2.conf
/etc/xdg/lightdm/lightdm-gtk-greeter.conf
/etc/lightdm/lightdm-gtk-greeter.conf.d/arch.conf
/etc/lightdm/lightdm-gtk-greeter.conf

lp://staging/~kalgasnik/lightdm-gtk-greeter/post-2.0.0 updated on 2015-03-27

325. By Andrew P. on 2015-03-27: conf.d support (LP: #1421587)

Revision history for this message

Simon Steinbeiß (ochosi) wrote on 2015-03-27:

Hey Andrew!
This is a huge amount of changes so I guess the branch-name is accurate :)
I wonder whether we could rip out some parts of it as bugfix for 2.0 and then do a bugfix release for it which we could then still upload to 15.04. Would that be possible?

Revision history for this message

Sean Davis (bluesabre) wrote on 2015-03-27:

Simon,

Actually, other than the configuration location (not really a "feature"), I'd say these are all bug fixes.

#1 is a critical bug that can leave the greeter completely non-functional.
#2 and #3 break accessibility by making the on-screen keyboard unusable.
#4 means that keyboard input would be lost without using a mouse.

I haven't tested the branch yet, but these all sound reasonable to me. I'll test it out this weekend.

lp://staging/~kalgasnik/lightdm-gtk-greeter/post-2.0.0 updated on 2015-03-29

326. By Andrew P. on 2015-03-29: Fallback if no .conf files found

Revision history for this message

Sean Davis (bluesabre) wrote on 2015-04-04:

I just tested this branch with a second monitor. It seems the white screen bug is still present.

Revision history for this message

Andrew P. (kalgasnik) wrote on 2015-04-05:

Log with allow-debugging=true?
Is it white "need to click or use active-monitor=0" screen?

Revision history for this message

Sean Davis (bluesabre) wrote on 2015-04-26:

I think I had some other components interfering. This time I built a proper package and installed it over a clean system, and everything seems to be okay. Going to merge this one in.

review: Approve