Merge lp://staging/~kaihengfeng/unity-settings-daemon/add-brightness-limit-mechanism into lp://staging/unity-settings-daemon
Proposed by
Kai-Heng Feng
Status: | Rejected |
---|---|
Rejected by: | Lars Karlitski |
Proposed branch: | lp://staging/~kaihengfeng/unity-settings-daemon/add-brightness-limit-mechanism |
Merge into: | lp://staging/unity-settings-daemon |
Diff against target: |
256 lines (+85/-13) 3 files modified
plugins/power/gpm-common.c (+32/-5) plugins/power/gpm-common.h (+15/-4) plugins/power/gsd-power-manager.c (+38/-4) |
To merge this branch: | bzr merge lp://staging/~kaihengfeng/unity-settings-daemon/add-brightness-limit-mechanism |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Lars Karlitski (community) | Disapprove | ||
Martin Pitt | Disapprove | ||
Ubuntu Desktop | Pending | ||
Review via email: mp+277416@code.staging.launchpad.net |
Description of the change
Add a mechanism that can make user to choose the minimum/maximum adjustable brightness level.
To post a comment you must log in.
Unmerged revisions
- 4118. By Kai-Heng Feng
-
power: Add a mechanism that can limit min/max brightness percentage via gsettings.
In attempt to fix #1381625, I think it should be the user to decide the minimun
brightness policy to be "screen dim" or "screen off". This newly added mechanism
does not change the current behavior, user can decide it by changing
"min-brightness-percentage" .
TBH, I'm not a fan of introducing configurability for such things. It sounds too much like an "unbreak my desktop setting" and a hack for a bug, it introduces combinatorial explosion again which nobody will test properly, and it'll be hard to drop such settings again.
My opinion is not authoritative here of course, it's ultimately the desktop teams' decision.