webbrowser-app

Merge lp://staging/~justinmcp/webbrowser-app/url-pattern-overrides into lp://staging/webbrowser-app

  1. url-pattern-overrides
  2. Merge into trunk
Proposed by Justin McPherson
Status: Rejected
Rejected by: Olivier Tilloy
Proposed branch: lp://staging/~justinmcp/webbrowser-app/url-pattern-overrides
Merge into: lp://staging/webbrowser-app
Diff against target: 22 lines (+5/-2)
1 file modified
src/app/webcontainer/WebApp.qml (+5/-2)
To merge this branch: bzr merge lp://staging/~justinmcp/webbrowser-app/url-pattern-overrides
Reviewer Review Type Date Requested Status
Alexandre Abreu (community) Disapprove
PS Jenkins bot continuous-integration Approve
Review via email: mp+212355@code.staging.launchpad.net

Commit message

Allow command line url matching to enhance app provided list.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:471
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/658/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4166
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3750
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-amd64-ci/160
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-ci/160
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-armhf-ci/160/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-trusty-i386-ci/160
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/3626
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4233
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4233/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3752
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3752/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/6054
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/5108

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/658/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

This is already taken care of by https://code.launchpad.net/~abreu-alexandre/webbrowser-app/fix-url-pattern-patching-overrides-and-google-patterns/+merge/209779

Revision history for this message
Alexandre Abreu (abreu-alexandre) :
review: Disapprove

Unmerged revisions

471. By Justin McPherson

Allow command line url matching to enhance app provided list.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: