Merge lp://staging/~justinmcp/unity-webapps-gmail/login-fix into lp://staging/unity-webapps-gmail

The change looks good, but it would feel safer if you could wrap a fragment of the webapp DOM into a unit test, to verify that the new expression matches some sample content.

FAILED: Continuous integration, rev:79
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~justinmcp/unity-webapps-gmail/login-fix/+merge/192095/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-webapps-gmail-ci/10/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-gmail-trusty-amd64-ci/3/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-gmail-trusty-armhf-ci/3/console

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity-webapps-gmail-ci/10/rebuild

FAILED: Continuous integration, rev:80
http://jenkins.qa.ubuntu.com/job/unity-webapps-gmail-ci/12/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-gmail-trusty-amd64-ci/5/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-gmail-trusty-armhf-ci/5/console

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity-webapps-gmail-ci/12/rebuild

FAILED: Continuous integration, rev:81
http://jenkins.qa.ubuntu.com/job/unity-webapps-gmail-ci/13/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-gmail-trusty-amd64-ci/6/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-gmail-trusty-armhf-ci/6/console

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity-webapps-gmail-ci/13/rebuild

FAILED: Continuous integration, rev:82
http://jenkins.qa.ubuntu.com/job/unity-webapps-gmail-ci/14/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-gmail-trusty-amd64-ci/7/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-gmail-trusty-armhf-ci/7/console

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity-webapps-gmail-ci/14/rebuild

Looks like you've got some jslint hassles there, Justin. If you run 'bzr bd' in your source tree it should invoke jslint for you, so you can test locally instead of having to push patches and wait for jenkins to show you the failures.

Hey, thanks for the tip, very helpful.

I wasn't sure (still not really) how deeply we follow jslint output, if you
look at it you can see a lot of warnings from code not involved in this
change, they must of been there before and were not causing a build error?

- Justin

On Wed, Nov 6, 2013 at 4:52 AM, Robert Bruce Park <<email address hidden>
> wrote:

> Looks like you've got some jslint hassles there, Justin. If you run 'bzr
> bd' in your source tree it should invoke jslint for you, so you can test
> locally instead of having to push patches and wait for jenkins to show you
> the failures.
> --
>
> https://code.launchpad.net/~justinmcp/unity-webapps-gmail/login-fix/+merge/192095
> You are the owner of lp:~justinmcp/unity-webapps-gmail/login-fix.
>

Mmmmm, well currently we actually fail hard on even the most minor of jslint violations. There was a (long) period of time where our jslint implementation was silently broken and didn't catch any violations, so it's entirely possible that there are many violations in trunk.

I think the best thing to do is just fix all the warnings (regardless of if they're your fault or not) so that trunk can be in better shape for the future.

Thanks!

FAILED: Continuous integration, rev:83
http://jenkins.qa.ubuntu.com/job/unity-webapps-gmail-ci/15/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-gmail-trusty-amd64-ci/8/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-gmail-trusty-armhf-ci/8/console

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity-webapps-gmail-ci/15/rebuild

Turns out the other jslint errors are filtered, and the error was with the
changed code.

I'll add the used function to style_checker.js later, but its not strictly
necessary now, and I've removed it.

On Wed, Nov 6, 2013 at 11:05 AM, Robert Bruce Park <
<email address hidden>> wrote:

> Mmmmm, well currently we actually fail hard on even the most minor of
> jslint violations. There was a (long) period of time where our jslint
> implementation was silently broken and didn't catch any violations, so it's
> entirely possible that there are many violations in trunk.
>
> I think the best thing to do is just fix all the warnings (regardless of
> if they're your fault or not) so that trunk can be in better shape for the
> future.
>
> Thanks!
> --
>
> https://code.launchpad.net/~justinmcp/unity-webapps-gmail/login-fix/+merge/192095
> You are the owner of lp:~justinmcp/unity-webapps-gmail/login-fix.
>

PASSED: Continuous integration, rev:84
http://jenkins.qa.ubuntu.com/job/unity-webapps-gmail-ci/16/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-gmail-trusty-amd64-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-gmail-trusty-armhf-ci/9

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity-webapps-gmail-ci/16/rebuild