Oxide

Merge lp://staging/~justinmcp/oxide/media-hub-audio-fixes into lp://staging/~oxide-developers/oxide/oxide.trunk

  1. media-hub-audio-fixes
  2. Merge into oxide.trunk
Proposed by Justin McPherson
Status: Merged
Merged at revision: 975
Proposed branch: lp://staging/~justinmcp/oxide/media-hub-audio-fixes
Merge into: lp://staging/~oxide-developers/oxide/oxide.trunk
Diff against target: 140 lines (+31/-23)
4 files modified
shared/browser/media/mediahub_player_shim.cc (+22/-16)
shared/browser/media/mediahub_player_shim.h (+1/-1)
shared/browser/media/oxide_player_media_hub.cc (+7/-5)
shared/browser/media/oxide_player_media_hub.h (+1/-1)
To merge this branch: bzr merge lp://staging/~justinmcp/oxide/media-hub-audio-fixes
Reviewer Review Type Date Requested Status
Chris Coulson Approve
Review via email: mp+249927@code.staging.launchpad.net

Commit message

Fixes to media-hub audio playback.

To post a comment you must log in.
lp://staging/~justinmcp/oxide/media-hub-audio-fixes updated
952. By Justin McPherson <justin@phablet-dev>

Don't capture the shared player instance.

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Thanks for this, although I'm not entirely sure what the fixes are for. I'll trust that they're correct :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches