Merge lp://staging/~justinmcp/media-hub/oxide-support into lp://staging/~phablet-team/media-hub/oxide-support

Proposed by Justin McPherson
Status: Merged
Approved by: Jim Hodapp
Approved revision: 45
Merged at revision: 43
Proposed branch: lp://staging/~justinmcp/media-hub/oxide-support
Merge into: lp://staging/~phablet-team/media-hub/oxide-support
Diff against target: 209 lines (+87/-8)
8 files modified
src/core/media/engine.h (+3/-0)
src/core/media/gstreamer/bus.h (+3/-1)
src/core/media/gstreamer/engine.cpp (+7/-0)
src/core/media/gstreamer/engine.h (+3/-0)
src/core/media/gstreamer/playbin.h (+44/-1)
src/core/media/player_implementation.cpp (+1/-5)
src/core/media/player_stub.cpp (+1/-1)
tests/unit-tests/test-gstreamer-engine.cpp (+25/-0)
To merge this branch: bzr merge lp://staging/~justinmcp/media-hub/oxide-support
Reviewer Review Type Date Requested Status
Jim Hodapp (community) code Approve
Review via email: mp+233152@code.staging.launchpad.net

Commit message

Support user-agent and cookies headers in http(s) source.

To post a comment you must log in.
Revision history for this message
Jim Hodapp (jhodapp) wrote :

Just one fix needed.

review: Needs Fixing (code)
45. By Justin McPherson <justin@phablet-dev>

Check for a null source in callback.

Revision history for this message
Jim Hodapp (jhodapp) wrote :

Looks good, thanks.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches