Juju Charms Collection
plumgrid-director package

Merge lp://staging/~junaidali/charms/trusty/plumgrid-director/trunk into lp://staging/~plumgrid-team/charms/trusty/plumgrid-director/trunk

  1. Trusty Tahr (14.04)
  2. trunk
  3. Merge into trunk
Proposed by Junaid Ali
Status: Merged
Merged at revision: 28
Proposed branch: lp://staging/~junaidali/charms/trusty/plumgrid-director/trunk
Merge into: lp://staging/~plumgrid-team/charms/trusty/plumgrid-director/trunk
Diff against target: 148 lines (+44/-24)
4 files modified
hooks/pg_dir_context.py (+10/-1)
hooks/pg_dir_hooks.py (+22/-18)
hooks/pg_dir_utils.py (+12/-1)
unit_tests/test_pg_dir_hooks.py (+0/-4)
To merge this branch: bzr merge lp://staging/~junaidali/charms/trusty/plumgrid-director/trunk
Reviewer Review Type Date Requested Status
Bilal Baqar Approve
Hassaan Pasha Pending
Review via email: mp+288399@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Bilal Baqar (bbaqar) wrote :

Made a few comments.

review: Needs Fixing
Revision history for this message
Bilal Baqar (bbaqar) :
review: Needs Fixing
lp://staging/~junaidali/charms/trusty/plumgrid-director/trunk updated
27. By Bilal Baqar

Made the following changes:
1. Reordered file and module imports
2. Sorted director IPs
3. Added unit fqdn in /etc/hosts of plumgrid-lxc
4. Loading plumgrid specific iptables on install
5. Added temporary upgrade hook to load iptables
6. stop_pg() is being used in restart_pg()
7. persistant iptables

28. By Bilal Baqar

Improved config-changed hook to perform steps according to the config changed

Revision history for this message
Bilal Baqar (bbaqar) :
review: Approve
Revision history for this message
Bilal Baqar (bbaqar) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches