Cable

Merge lp://staging/~julien-spautz/cable/pm into lp://staging/cable

  1. pm
  2. Merge into trunk
Proposed by Julien Spautz
Status: Merged
Merged at revision: 139
Proposed branch: lp://staging/~julien-spautz/cable/pm
Merge into: lp://staging/cable
Diff against target: 1358 lines (+509/-388)
16 files modified
CMakeLists.txt (+2/-0)
src/Controller/Channel.vala (+18/-17)
src/Controller/PrivateChat.vala (+85/-0)
src/Controller/Server.vala (+32/-12)
src/Controller/Window.vala (+28/-38)
src/Utils/HostMask.vala (+31/-0)
src/View/Channel.vala (+22/-22)
src/View/Server.vala (+21/-54)
src/View/Window.vala (+2/-2)
src/Widgets/Channel.vala (+68/-61)
src/Widgets/ChatDisplay.vala (+1/-24)
src/Widgets/Room.vala (+38/-118)
src/Widgets/Server.vala (+26/-35)
src/Widgets/User.vala (+8/-0)
src/Widgets/UserList.vala (+122/-0)
src/Widgets/Window.vala (+5/-5)
To merge this branch: bzr merge lp://staging/~julien-spautz/cable/pm
Reviewer Review Type Date Requested Status
Julien Spautz Approve
Review via email: mp+186069@code.staging.launchpad.net

Description of the change

This branch implements basic private chat features.

A chat will be opened when you receive a /msg or when you double click on a name in the user list.

To post a comment you must log in.
Revision history for this message
Julien Spautz (julien-spautz) wrote :

Now open for review.

Revision history for this message
982c80311320c1b (alexander-wilms) wrote :

Compiles and works as expected

Revision history for this message
Daniele "OpenNingia" Simonetti (oppifjellet) wrote :

Compiles and works with some quirks:

* You can have a private chat with yourself that is quite confusing.
* IRC commands ( e.g. /join ) don't work in the private chat window.

lp://staging/~julien-spautz/cable/pm updated
146. By Julien Spautz

don't allow talking to yourself (you weirdo)

Revision history for this message
Julien Spautz (julien-spautz) wrote :

Private chats with yourself have been fixed.

IRC commands will need some more code shifting, but I don't want to unnecessarily bloat the diff, so that's for another merge.

This branch should allow basic private chat functionality including opening chats by double clicking a name and when receiving a /msg.

Revision history for this message
Julien Spautz (julien-spautz) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: