Cable

Merge lp://staging/~julien-spautz/cable/irc-commands into lp://staging/cable

irc-commands
Merge into trunk

Proposed by Julien Spautz on 2013-08-16

Status:

Merged

Merged at revision:

122

Proposed branch:

lp://staging/~julien-spautz/cable/irc-commands

Merge into:

lp://staging/cable

Diff against target:

456 lines (+288/-6) (has conflicts)

12 files modified

src/Controller/Channel.vala (+105/-5)
src/Controller/Server.vala (+19/-0)
src/Controller/Window.vala (+19/-0)
src/Irc/Channel.vala (+6/-0)
src/Settings/Preferences.vala (+19/-0)
src/Settings/SavedState.vala (+22/-0)
src/Tests/Tests.vala (+19/-0)
src/Tests/Utils.vala (+19/-0)
src/View/Channel.vala (+19/-0)
src/View/Server.vala (+19/-0)
src/View/Window.vala (+19/-0)
src/Widgets/ChatDisplay.vala (+3/-1)

Text conflict in src/Settings/SavedState.vala

To merge this branch:

bzr merge lp://staging/~julien-spautz/cable/irc-commands

Critical

In Progress

Link a bug report

Reviewer	Review Type	Date Requested	Status
Eduard Gotwig (community)		2013-08-16	Needs Fixing on 2013-08-18
Review via email: mp+180624@code.staging.launchpad.net

Description of the change

Started implementing irc commands. Also added support for actions (/me or /action) because they where not displayed previously. Also added missing copyright headers.

I only implemented a few commands so far, which should I add next?

Revision history for this message

Eduard Gotwig (gotwig) wrote on 2013-08-17:

Why can't you forward all commands, which beginn with a "/"?

Revision history for this message

Julien Spautz (julien-spautz) wrote on 2013-08-17:

It does forward all unknown commands.

Some commands, like /me, do not exits in the IRC protocol, so you can't just forward them, if that's what you mean.

Revision history for this message

Eduard Gotwig (gotwig) wrote on 2013-08-18:

Ok, I think "/describe" is not there.

Also I found here a nice list: http://www.greenday.net/chat/commands.html .

Also, for autocompletition, it should first check if the entry is free, does not contain any charachters, and only than add ":" to the username. Else it should just autocomplete the username, without :.

Example: if you type /describe ma<TAB> the result is
/describe max: instead of /describe max, so the user has to remove the ":" manually.

This also happens when you want to refer to a user, in the chat.

example: Hello ma<TAB>
results in Hello max: .

This is not what we want, instead we want "Hello max".

Thanks for your work Julien, it seems to work for me.

review: Needs Fixing

Revision history for this message

Marcus Lundgren (marcus-lundgren) wrote on 2013-08-18:

A list of the available IRC commands that might be of help: http://en.wikipedia.org/wiki/List_of_Internet_Relay_Chat_commands

At a glance, you seem to be missing /quit.

lp://staging/~julien-spautz/cable/irc-commands updated on 2013-08-24