Cable

Merge lp://staging/~julien-spautz/cable/authors-hacking-thanks into lp://staging/cable

Proposed by Julien Spautz on 2013-08-20

Status:	Merged
Approved by:	Eduard Gotwig on 2013-08-21
Approved revision:	119
Merged at revision:	118
Proposed branch:	lp://staging/~julien-spautz/cable/authors-hacking-thanks
Merge into:	lp://staging/cable
Diff against target:	297 lines (+142/-123) 5 files modified AUTHORS (+5/-0) HACKING (+121/-0) README.rst (+0/-121) THANKS (+10/-0) src/Cable.vala (+6/-2)
To merge this branch:	bzr merge lp://staging/~julien-spautz/cable/authors-hacking-thanks
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Eduard Gotwig (community)		2013-08-20	Needs Fixing on 2013-08-20
Review via email: mp+180967@code.staging.launchpad.net

added AUTHORS and THANKS files
renamed README to HACKING

Revision history for this message

Tom Beckmann (tombeckmann) wrote on 2013-08-20:

My email changed a while ago, it's tomjonabc(at)gmail(dot)com now, did you find it that way somewhere else? Maybe I should fix it there too. Thanks!

Revision history for this message

Julien Spautz (julien-spautz) wrote on 2013-08-20:

I found it in the src/Cable.vala file. Don't worry, I'll fix it for you.

Revision history for this message

Eduard Gotwig (gotwig) wrote on 2013-08-20:

I would be glad if you could add

and

to the contributors part.

They've done a great job on Cable development and bug fixing!

btw. when can we merge this?

review: Needs Fixing

Revision history for this message

Julien Spautz (julien-spautz) wrote on 2013-08-21:

The branch is ready to be merged now.

> I would be glad if you could add
>
>
> https://launchpad.net/~oppifjellet
>
> and
>
> https://launchpad.net/~nkanaev
>
> to the contributors part.
>
> They've done a great job on Cable development and bug fixing!
>
> btw. when can we merge this?