Merge lp://staging/~juliank/software-properties/add-apt-repository-run-update into lp://staging/software-properties
Proposed by
Julian Andres Klode
| Status: | Merged |
|---|---|
| Approved by: | Balint Reczey |
| Approved revision: | 1006 |
| Merged at revision: | 1004 |
| Proposed branch: | lp://staging/~juliank/software-properties/add-apt-repository-run-update |
| Merge into: | lp://staging/software-properties |
| Diff against target: |
58 lines (+25/-2) 2 files modified
add-apt-repository (+19/-2) debian/changelog (+6/-0) |
| To merge this branch: | bzr merge lp://staging/~juliank/software-properties/add-apt-repository-run-update |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Steve Langasek | Approve | ||
| Balint Reczey | Approve | ||
|
Review via email:
|
|||
Description of the change
This automatically runs apt-get update after adding repositories. While SoftwareProperties can already do updates, it only does them for shortcuts, not for enabling components. It also shows no progress or anything.
We could modify it to run always and show progress, but this seems like it could cause potential problems when the same code is used elsewhere, for example in the dbus client.
Also, the Python text progress implementation might have problems not in the C++ version, so it's best to just execvp() apt-get when we're done.
To post a comment you must log in.
Revision history for this message
| Julian Andres Klode (juliank) wrote | # |
Revision history for this message
| Balint Reczey (rbalint) | # |
review:
Needs Information
Revision history for this message
| Julian Andres Klode (juliank) | # |
Revision history for this message
| Balint Reczey (rbalint) | # |
Revision history for this message
| Balint Reczey (rbalint) | # |
review:
Approve
Revision history for this message
| Julian Andres Klode (juliank) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Optimally we would only update the source we have added. But this is problematic if the source shares the same Release file with an existing source (everything with the same Release file needs to be updated together). Figuring out which entries share the same Release file, and then creating a temporary sources.list to update only them would be possible, but it seems a bit too fragile.