Merge lp://staging/~juliank/merge-o-matic/javascript-query into lp://staging/merge-o-matic

Proposed by Julian Andres Klode
Status: Merged
Merged at revision: 309
Proposed branch: lp://staging/~juliank/merge-o-matic/javascript-query
Merge into: lp://staging/merge-o-matic
Diff against target: 84 lines (+61/-0)
1 file modified
merge-status.py (+61/-0)
To merge this branch: bzr merge lp://staging/~juliank/merge-o-matic/javascript-query
Reviewer Review Type Date Requested Status
Julian Andres Klode Approve
Colin Watson (community) Approve
Review via email: mp+336671@code.staging.launchpad.net

Description of the change

This adds a search box and two check boxes for:

- merges with uploads in proposed
- merges without them

This uses the history modification API thingy, and replaces the search part of the URL, so you end up with queries like:

https://merges.ubuntu.com/main.html?query=foundations-bugs&showProposed=false&showMergeNeeded=true

I tested that the JavaScript and HTML works, but I might have messed up the integration into the Python script. I lack the files to test the merge-status.py script on my system.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve
313. By Julian Andres Klode

use === instead of == and fix an empty line that got inserted somehow

314. By Julian Andres Klode

Some more == to === fixes

Revision history for this message
Julian Andres Klode (juliank) wrote :

Verified that it generates the same output as my test file, so it's good to go.

review: Approve
Revision history for this message
Tiago Stürmer Daitx (tdaitx) wrote :

Case insensitive search can be done by using toUpperCase() - or toLowerCase().

Example: !rows[i].textContent.toUpperCase().match(query.value.toUpperCase()).

Revision history for this message
Julian Andres Klode (juliank) wrote :

Might be better to just make the regex case insensitive, AKA

new RegExp(query.value, "i")

but that will be a new MP :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: