Merge lp://staging/~julian-edwards/launchpad/metadata-type-bug-595038 into lp://staging/launchpad

Proposed by Julian Edwards
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merged at revision: 11036
Proposed branch: lp://staging/~julian-edwards/launchpad/metadata-type-bug-595038
Merge into: lp://staging/launchpad
Diff against target: 179 lines (+133/-0)
5 files modified
lib/lp/archivepublisher/tests/publishing-meta-data-files.txt (+65/-0)
lib/lp/archiveuploader/nascentuploadfile.py (+2/-0)
lib/lp/archiveuploader/tests/meta-data-custom-files.txt (+21/-0)
lib/lp/soyuz/interfaces/queue.py (+18/-0)
lib/lp/soyuz/model/queue.py (+27/-0)
To merge this branch: bzr merge lp://staging/~julian-edwards/launchpad/metadata-type-bug-595038
Reviewer Review Type Date Requested Status
Jelmer Vernooij (community) code Approve
Review via email: mp+27837@code.staging.launchpad.net

Description of the change

= Summary =
Add meta-data custom upload type for use by the Software Center.

== Implementation details ==
This branch defines a new custom upload type, META_DATA, which is defined by a
file's section being "meta-data".

The file's format is of no concern to Soyuz, it simply lives in the librarian
and is published to an area outside of the repo so that if the repo is
private, the meta-data is still accessible.

== Tests ==
bin/test -cvvt publishing-meta-data-files.txt -t meta-data-custom-files.txt

== Demo and Q/A ==
We need to make a source package with a meta-data custom file attached and
upload. It should get accepted as normal and published appropriately.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/model/queue.py
  lib/lp/soyuz/interfaces/queue.py
  lib/lp/archivepublisher/tests/publishing-meta-data-files.txt
  lib/lp/archiveuploader/nascentuploadfile.py
  lib/lp/archiveuploader/tests/meta-data-custom-files.txt

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

lib/lp/archiveuploader/tests/meta-data-custom-files.txt uses the British spelling of "Software Centre".

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Nice, surprising to see how easy it is to add another custom file type.

The enum value "META_DATA" doesn't really describe to me what this data is about to me, as everything that is not the package itself (changes, dsc files) could be considered metadata. CATALOGUE perhaps, or something that explicitly refers to software center?

review: Needs Information (code)
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Thanks for the review Jelmer.

I think CATALOGUE is another can of worms, because the US spelling is CATALOG. I also don't think changing the enum name itself will help a lot, to be honest, but the doctest and the enum text should be very clear and easy to understand. Is there anything in those you think can be improved?

J

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Oops, I hadn't realized catalogue was also UK English. :-) The enum value name was a minor issue, I think it's sufficiently documented and fine to land as is.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.