-
-
Package Description
We noticed a few things. First, the def label() should not be necessary.
I'll update my branch so that the base-layout falls back to view.context.title
when view.label is not defined. Second, by default base-layout cgi.escapes
the label, but it should also smartquote it. Third, I think you can basically
get rid of DistroSeriesBinaryPackageView. Once my branch lands, there'll be
no reason not to just use LaunchpadView. Removing code rocks!
rs=me for all those follow up changes (though of course, I'm happy to review
the branch if you want).
In the meantime, I have only a minor suggestion for something to fix as your
branch stands now, so r=me with its consideration. The branch looks great,
thanks.
review approve
status approve
>or
>https://dogfood.launchpad.net/ubuntu/hardy/+package/kmail
>
>= Launchpad lint =
>
>Checking for conflicts. and issues in doctests and templates.
>Running jslint, xmllint, pyflakes, and pylint.
>Using normal rules.
>
>Linting changed files:
> lib/lp/registry/browser/sourcepackage.py
> lib/lp/soyuz/templates/sourcepackage-builds.pt
> lib/lp/soyuz/browser/sourcepackagebuilds.py
> lib/lp/soyuz/templates/distroseriesbinarypackage-index.pt
> lib/lp/soyuz/browser/configure.zcml
>
=== added file 'lib/lp/soyuz/browser/sourcepackagebuilds.py'
--- lib/lp/soyuz/browser/sourcepackagebuilds.py 1970-01-01 00:00:00 +0000
+++ lib/lp/soyuz/browser/sourcepackagebuilds.py 2009-09-04 12:22:22 +0000
> @@ -0,0 +1,37 @@
> +# Copyright 2009 Canonical Ltd. This software is licensed under the
> +# GNU Affero General Public License version 3 (see the file LICENSE).
> +
> +"""Browser views for source package builds."""
> +
> +__metaclass__ = type
> +
> +__all__ = [
> + 'SourcePackageBuildsView',
> + ]
> +
> +from lp.soyuz.browser.build import BuildRecordsView
> +from canonical.lazr.utils import smartquote
> +
> +
> +class SourcePackageBuildsView(BuildRecordsView):
> + """A view for (distro series) source package builds."""
> +
> + @property
> + def page_title(self):
> + return smartquote("Builds for " + self.context.title)
This will likely change too once my branch lands, but I didn't try to convert
this view/page/template to the new header stuff. The rs=me above applies to
this as well.
> +
> + @property
> + def search_name(self):
> + """Direct the builds-list template to omit the name search field."""
> + return False
> +
> + @property
> + def default_build_state(self):
> + """Default build state for sourcepackage builds.
> +
> + This overrides the default that is set on BuildRecordsView."""
Close quote on the next line.
> + # None maps to "all states". The reason we display all states on
> + # this page is because it's unlikely that there will be so
> + # many builds that the listing will be overwhelming.
> + return None
> +
=== modified file 'lib/lp/soyuz/templates/distroseriesbinarypackage-index.pt'
--- lib/lp/soyuz/templates/distroseriesbinarypackage-index.pt 2009-09-03 16:38:19 +0000
+++ lib/lp/soyuz/templates/distroseriesbinarypackage-index.pt 2009-09-04 12:43:13 +0000
> @@ -9,12 +9,12 @@
>
>
>
> -
> +
>
>
>
>
> -
> +
See above.
>
>
> Package Description
=== modified file 'lib/lp/soyuz/templates/sourcepackage-builds.pt'
--- lib/lp/soyuz/templates/sourcepackage-builds.pt 2009-07-17 17:59:07 +0000
+++ lib/lp/soyuz/templates/sourcepackage-builds.pt 2009-09-04 12:06:54 +0000
> @@ -3,26 +3,15 @@
> xmlns:tal="http://xml.zope.org/namespaces/tal"
> xmlns:metal="http://xml.zope.org/namespaces/metal"
> xmlns:i18n="http://xml.zope.org/namespaces/i18n"
> - xml:lang="en"
> - lang="en"
> - dir="ltr"
> - metal:use-macro="context/@@main_template/master"
> + metal:use-macro="view/macro:page/main_only"
> i18n:domain="launchpad"
> >
>
>
>
> -
> -
> -
> -
> -
> -
> -
> -
>
>
> -
builds
> +
See above.
>
>
>