Merge lp://staging/~julian-edwards/launchpad/delete-packages-api-bug-687298 into lp://staging/launchpad
| Status: | Merged |
|---|---|
| Approved by: | Julian Edwards |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 12033 |
| Proposed branch: | lp://staging/~julian-edwards/launchpad/delete-packages-api-bug-687298 |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
176 lines (+56/-16) 3 files modified
lib/lp/soyuz/interfaces/publishing.py (+15/-2) lib/lp/soyuz/model/publishing.py (+13/-0) lib/lp/soyuz/stories/webservice/xx-source-package-publishing.txt (+28/-14) |
| To merge this branch: | bzr merge lp://staging/~julian-edwards/launchpad/delete-packages-api-bug-687298 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jelmer Vernooij (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
When deleting source packages on the API, make sure their binaries are deleted too so they're not left in limbo.
Description of the change
Currently when source packages are deleted on the API it leaves their binaries undeleted and in limbo. This causes the publisher to consider the packages for condemning each and every cycle it runs, which can cause huge delays (the data fixed in production caused by this bug has changed the cycle from 40 minutes to 5).
This branch fixes that by making a special requestDeletion() just for the API which calls requestDeletion() on IPublishingSet instead (which is what the UI does).
The story test is a little nasty I'm afraid, I had to also convert it to use a different distroseries that's set up for binary publications.
At some point it would be nice to convert it to a propert unit test, but not today.
| Jelmer Vernooij (jelmer) | # |
