Merge lp://staging/~julian-edwards/launchpad/cancel-build-bug-173018-ui-part4 into lp://staging/launchpad
Proposed by
Julian Edwards
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Julian Edwards | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 14241 | ||||
Proposed branch: | lp://staging/~julian-edwards/launchpad/cancel-build-bug-173018-ui-part4 | ||||
Merge into: | lp://staging/launchpad | ||||
Prerequisite: | lp://staging/~julian-edwards/launchpad/cancel-build-bug-173018-ui-part3 | ||||
Diff against target: | 0 lines | ||||
To merge this branch: | bzr merge lp://staging/~julian-edwards/launchpad/cancel-build-bug-173018-ui-part4 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeroen T. Vermeulen (community) | Approve | ||
Review via email: mp+80997@code.staging.launchpad.net |
Commit message
[r=jtv][bug=173018] Add a cancellation link and button on build pages.
Description of the change
= Summary =
Final branch in pipeline of changes to add build cancellation.
== Proposed fix ==
Add a cancellation link/button on build pages.
== Pre-implementation notes ==
Pre-what? :)
== Implementation details ==
Similar to the cancellation for recipe builds, this adds a traversal to
+cancel from a binary build which uses the general edit template.
Most of the change is pretty boilerplate.
== Tests ==
bin/test -cvv test_build_views
== Demo and Q/A ==
Already tested on Dogfood, works like a charm.
To post a comment you must log in.
Looks good. As per my find-something- or-they- won't-know- you've- read-it policy, I think the sentences that can go into the notification box should end in full stops.