Merge lp://staging/~julian-edwards/gwacl/network-configuration into lp://staging/gwacl

Proposed by Julian Edwards
Status: Merged
Approved by: Gavin Panella
Approved revision: 173
Merged at revision: 169
Proposed branch: lp://staging/~julian-edwards/gwacl/network-configuration
Merge into: lp://staging/gwacl
Diff against target: 197 lines (+176/-0)
2 files modified
xmlobjects.go (+70/-0)
xmlobjects_test.go (+106/-0)
To merge this branch: bzr merge lp://staging/~julian-edwards/gwacl/network-configuration
Reviewer Review Type Date Requested Status
Gavin Panella Approve
Review via email: mp+173647@code.staging.launchpad.net

Commit message

Add the SetNetworkConfiguration request xml

Description of the change

Add the SetNetworkConfiguration request xml.

I learned several things while getting bogged down for hours in this branch:

1. You can't put ",attr" in an xml chain like this `xml:"node>subnode,attr"` it just gets silently ignored and becomes an attr of the containing struct's node name.
2. Go will panic in its marshaller if you try and define multiple attrs on a node using an array
3. Because of (1) you need to write stupidly complex deep structs if a low-level node needs an attr
4. I need more coffee to deal with this crap
5. xml parsing in Go is utterly hideous
6. The Equals checker could do with diff output for large strings; it feels like going back to huge failing doctests
7. Kill me now.

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Oh one more thing I learned:

It won't marshal an empty value to <node/>, instead it always writes <node></node> so I had to take the liberty of amending the template from the Azure documentation.

Revision history for this message
Gavin Panella (allenap) wrote :

The hoops that we have to jump through keep us fit. And break our knees.

review: Approve
Revision history for this message
Julian Edwards (julian-edwards) wrote :

On 10/07/13 00:19, Gavin Panella wrote:
> The hoops that we have to jump through keep us fit. And break our knees.

My knees feel like they ran a marathon.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: