Merge lp://staging/~julian-edwards/gwacl/network-configuration into lp://staging/gwacl
Status: | Merged |
---|---|
Approved by: | Gavin Panella |
Approved revision: | 173 |
Merged at revision: | 169 |
Proposed branch: | lp://staging/~julian-edwards/gwacl/network-configuration |
Merge into: | lp://staging/gwacl |
Diff against target: |
197 lines (+176/-0) 2 files modified
xmlobjects.go (+70/-0) xmlobjects_test.go (+106/-0) |
To merge this branch: | bzr merge lp://staging/~julian-edwards/gwacl/network-configuration |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gavin Panella | Approve | ||
Review via email:
|
Commit message
Add the SetNetworkConfi
Description of the change
Add the SetNetworkConfi
I learned several things while getting bogged down for hours in this branch:
1. You can't put ",attr" in an xml chain like this `xml:"node>
2. Go will panic in its marshaller if you try and define multiple attrs on a node using an array
3. Because of (1) you need to write stupidly complex deep structs if a low-level node needs an attr
4. I need more coffee to deal with this crap
5. xml parsing in Go is utterly hideous
6. The Equals checker could do with diff output for large strings; it feels like going back to huge failing doctests
7. Kill me now.
Oh one more thing I learned:
It won't marshal an empty value to <node/>, instead it always writes <node></node> so I had to take the liberty of amending the template from the Azure documentation.