Merge lp://staging/~julian-edwards/gwacl/listhostedservices into lp://staging/gwacl
Proposed by
Julian Edwards
| Status: | Merged |
|---|---|
| Approved by: | Julian Edwards |
| Approved revision: | 163 |
| Merged at revision: | 159 |
| Proposed branch: | lp://staging/~julian-edwards/gwacl/listhostedservices |
| Merge into: | lp://staging/gwacl |
| Diff against target: |
147 lines (+84/-9) 3 files modified
management_base_test.go (+5/-5) xmlobjects.go (+17/-4) xmlobjects_test.go (+62/-0) |
| To merge this branch: | bzr merge lp://staging/~julian-edwards/gwacl/listhostedservices |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Raphaël Badin (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Fix ListHostedServices and give it a test.
Description of the change
I sat down to write ListHostedServices and saw that it was already written. However, its implementation was broken and not surprisingly there were no tests for it. It's all fixed here, and I even improved the existing test TestListHostedS
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good!
I ran the example file (which already called the old version of the method) and everything is okay.