Merge lp://staging/~julian-edwards/gwacl/getblocklist into lp://staging/gwacl

Proposed by Julian Edwards
Status: Merged
Approved by: Julian Edwards
Approved revision: 55
Merged at revision: 55
Proposed branch: lp://staging/~julian-edwards/gwacl/getblocklist
Merge into: lp://staging/gwacl
Diff against target: 188 lines (+148/-0)
4 files modified
storage.go (+32/-0)
storage_test.go (+64/-0)
xmlobjects.go (+16/-0)
xmlobjects_test.go (+36/-0)
To merge this branch: bzr merge lp://staging/~julian-edwards/gwacl/getblocklist
Reviewer Review Type Date Requested Status
Gavin Panella Approve
Review via email: mp+154864@code.staging.launchpad.net

Commit message

GetBlockList added to retrieve the list of blocks for a file.

To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) wrote :

Looks good. Something Jeroen pointed out: gocheck has NotNil which can be used as an shorthand for Not(IsNil).

review: Approve
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Attempt to merge into lp:gwacl failed due to conflicts:

text conflict in storage_test.go

55. By Julian Edwards

merge trunk to resolve conflict

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: