Go Windows Azure Client Library

Merge lp://staging/~julian-edwards/gwacl/deletedisk into lp://staging/gwacl

  1. deletedisk
  2. Merge into trunk
Proposed by Julian Edwards
Status: Merged
Approved by: Julian Edwards
Approved revision: 185
Merged at revision: 179
Proposed branch: lp://staging/~julian-edwards/gwacl/deletedisk
Merge into: lp://staging/gwacl
Diff against target: 971 lines (+150/-103)
10 files modified
deletedisk_test.go (+3/-3)
management_base.go (+63/-30)
management_base_test.go (+30/-28)
management_test.go (+2/-5)
poller.go (+2/-1)
poller_test.go (+3/-3)
x509dispatcher.go (+8/-11)
x509dispatcher_test.go (+15/-6)
x509session.go (+8/-8)
x509session_test.go (+16/-8)
To merge this branch: bzr merge lp://staging/~julian-edwards/gwacl/deletedisk
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) Approve
Review via email: mp+174337@code.staging.launchpad.net

Commit message

Ensures each api call specifies its own x-ms-version and add Azure url links to relevant docs for each api call

Description of the change

I was intending this to be a fix for the disk deletion problem (http://paste.ubuntu.com/5864779/) but it doesn't work. However this branch still sorts out a few things:

 1. Adds Azure url links to relevant docs for each api call
 2. Ensures each api call specifies its own x-ms-version. This is critical to prevent future cock ups and also because the deletedisk call requires a version other than the old base version.
 3. Adds extra test coverage that was missing which ensures x-ms-header is set for all the session op methods.

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Well I tell a lie - disk deletion has worked, so this fixes that too.

However the example program is still not cleaning up the storage, that needs looking at still.

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Good stuff. Consistent function documentation is lagniappe, but particularly appreciated. Sometimes a top comment for a function doesn't help understanding per se, but I still find that applying them inconsistently can frustrate the scanning of code. It's as if it makes my eyes recover from an exception rather than processing the text in a straight loop.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: