Merge lp://staging/~julian-edwards/gwacl/delete-container into lp://staging/gwacl
Proposed by
Julian Edwards
| Status: | Merged |
|---|---|
| Approved by: | Julian Edwards |
| Approved revision: | 204 |
| Merged at revision: | 204 |
| Proposed branch: | lp://staging/~julian-edwards/gwacl/delete-container |
| Merge into: | lp://staging/gwacl |
| Diff against target: |
95 lines (+74/-0) 2 files modified
storage_base.go (+19/-0) storage_base_test.go (+55/-0) |
| To merge this branch: | bzr merge lp://staging/~julian-edwards/gwacl/delete-container |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jeroen T. Vermeulen (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Add the DeleteContainer storage call.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good, given the difficulties with unit-testing in Go. Maybe in addition to testing that deliberately induced errors come out as non-nil, you could also cursorily check their contents.
Use the ErrorMatches checker to verify that an error matches a given regex:
// Don't care what else is in the error, but the original error message
// must be in there somewhere.
c.Check(err, ErrorMatches, ".*canned error.*")