Merge lp://staging/~julian-edwards/gwacl/augment-rolesizes into lp://staging/gwacl

Proposed by Julian Edwards
Status: Merged
Approved by: Julian Edwards
Approved revision: 196
Merged at revision: 198
Proposed branch: lp://staging/~julian-edwards/gwacl/augment-rolesizes
Merge into: lp://staging/gwacl
Diff against target: 141 lines (+60/-24)
2 files modified
rolesizes.go (+44/-24)
rolesizes_test.go (+16/-0)
To merge this branch: bzr merge lp://staging/~julian-edwards/gwacl/augment-rolesizes
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) Approve
Review via email: mp+176108@code.staging.launchpad.net

Commit message

Add more comments, better units and an extra map of role names to role sizes, with thanks to jtv for his ideas.

Description of the change

Taking inspiration from https://code.launchpad.net/~jtv/gwacl/machine-types/+merge/175736 which unfortunately was done at the same time as something I did for this, I've enhanced what I already landed with jtv's ideas.

To post a comment you must log in.
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Thanks for integrating this. It may seem strange that I used thousandths of US dollars in my branch, but that's also what Juju's EC2 provider does. EC2's pricing structure makes use of the extra precision, and Microsoft may find they'll want to tweak their pricing more.

I think it's still worth saying in so many words that we make no guarantees with these cost indications and that we'll happily let them go out of date if no updates are required for our purposes. Otherwise, your statement that the information is correct (do we even really know that?) as of a given date may reasonably be construed as a promise to keep the list updated.

review: Approve
Revision history for this message
Julian Edwards (julian-edwards) wrote :

On 23/07/13 12:44, Jeroen T. Vermeulen wrote:
> Review: Approve
>
> Thanks for integrating this. It may seem strange that I used thousandths of US dollars in my branch, but that's also what Juju's EC2 provider does. EC2's pricing structure makes use of the extra precision, and Microsoft may find they'll want to tweak their pricing more.
>
> I think it's still worth saying in so many words that we make no guarantees with these cost indications and that we'll happily let them go out of date if no updates are required for our purposes. Otherwise, your statement that the information is correct (do we even really know that?) as of a given date may reasonably be construed as a promise to keep the list updated.
>

Normally saying something like that means you know it's correct as of a
certain date but you make no guarantees it's correct at a later date.
It just means you checked it on that date.

Thanks for the review!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: