lpci

Merge ~jugmac00/lpci:fix-deprecation-use_snapshots into lpci:main

  1. Git
  2. lp:~jugmac00/lpci
  3. fix-deprecation-use_snapshots
  4. Merge into main
Proposed by Jürgen Gmach
Status: Merged
Merged at revision: bec65b122e65f165451d752bc3f1f2a13d7dd5fc
Proposed branch: ~jugmac00/lpci:fix-deprecation-use_snapshots
Merge into: lpci:main
Diff against target: 113 lines (+19/-12)
5 files modified
NEWS.rst (+7/-0)
lpcraft/providers/_lxd.py (+2/-2)
lpcraft/providers/tests/test_lxd.py (+1/-1)
requirements.txt (+8/-8)
setup.cfg (+1/-1)
Reviewer Review Type Date Requested Status
Guruprasad Approve
Review via email: mp+437782@code.staging.launchpad.net

Commit message

Fix deprecation warning in `lxd.launch`

To post a comment you must log in.
Revision history for this message
Jürgen Gmach (jugmac00) wrote :

see https://github.com/canonical/craft-providers/blob/main/docs/changelog.rst#170-2023-01-11

Revision history for this message
Guruprasad (lgp171188) wrote :

The relevant lines in the changelog are:

> For the LXD launch function launched_environment, the parameter use_snapshots has been replaced by use_base_instance. use_snapshots still works but logs a deprecation notice.

Revision history for this message
Guruprasad (lgp171188) wrote :

LGTM 👍

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches