Merge ~jugmac00/lpci:provide-additional-repositories-via-cli into lpci:main
Proposed by
Jürgen Gmach
| Status: | Merged |
|---|---|
| Merged at revision: | 8326798867e576719be700d3d6e23ea0be464496 |
| Proposed branch: | ~jugmac00/lpci:provide-additional-repositories-via-cli |
| Merge into: | lpci:main |
| Diff against target: |
512 lines (+311/-25) 5 files modified
NEWS.rst (+1/-1) docs/cli-interface.rst (+27/-10) lpcraft/commands/run.py (+38/-11) lpcraft/commands/tests/test_run.py (+244/-2) lpcraft/config.py (+1/-1) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Colin Watson (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Enable providing additional repositories via CLI
To post a comment you must log in.
Revision history for this message
| Colin Watson (cjwatson) | # |
review:
Approve
Revision history for this message
| Jürgen Gmach (jugmac00) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for the review, Colin!
Indeed - CLI options should be more important than configuration options. Actually, I thought I did this, but obviously I was not aware what takes precedence -> TIL
I also added a test which shows the new order.