lpci

Merge ~jugmac00/lpci:add-pre-post-run-hooks into lpci:main

  1. Git
  2. lp:~jugmac00/lpci
  3. add-pre-post-run-hooks
  4. Merge into main
Proposed by Jürgen Gmach
Status: Merged
Merged at revision: 185c673ec63960aa05e9b0b7e8e6f44660c6f799
Proposed branch: ~jugmac00/lpci:add-pre-post-run-hooks
Merge into: lpci:main
Diff against target: 374 lines (+174/-82)
6 files modified
NEWS.rst (+4/-1)
docs/configuration.rst (+8/-0)
lpcraft/commands/run.py (+144/-81)
lpcraft/config.py (+2/-0)
lpcraft/plugin/hookspecs.py (+12/-0)
lpcraft/tests/test_config.py (+4/-0)
Reviewer Review Type Date Requested Status
Jürgen Gmach Approve
Review via email: mp+423399@code.staging.launchpad.net

Commit message

This branch adds pre- and post- run hooks to jobs in lpcraft via the `run-before` and `run-after` configuration keys and the `lpcraft_execute_before_run` and `lpcraft_execute_after_run` hooks for plugins to configure.

It also includes a slight refactor of the `run_job` logic to avoid code duplication.

To post a comment you must log in.
Revision history for this message
Jürgen Gmach (jugmac00) wrote :

self-approving as the main parts were already improved and just a bit of documentation and changelog entries were added

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches