Merge lp://staging/~jtyr/terminator/terminator into lp://staging/terminator/trunk
Proposed by
Jiri Tyr
Status: | Merged |
---|---|
Merged at revision: | 1564 |
Proposed branch: | lp://staging/~jtyr/terminator/terminator |
Merge into: | lp://staging/terminator/trunk |
Diff against target: |
164 lines (+85/-2) 5 files modified
doc/terminator_config.5 (+4/-0) terminatorlib/config.py (+1/-0) terminatorlib/preferences.glade (+53/-0) terminatorlib/prefseditor.py (+22/-0) terminatorlib/terminator.py (+5/-2) |
To merge this branch: | bzr merge lp://staging/~jtyr/terminator/terminator |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stephen Boddy | Approve | ||
Jiri Tyr (community) | Needs Resubmitting | ||
Review via email: mp+209719@code.staging.launchpad.net |
Description of the change
I have noticed that the Broadcast is set to "group" by default. I believe that this is wrong and it should be set to "off" by default.
To post a comment you must log in.
Hi Jiri, as the current maintainer and original contributor of that area of code I disagree that the current behaviour is wrong. The groups are there to facilitate flexible broadcast modes. If you don't need to broadcast there's not much (if any) need to use groups. By default new terminals do not get a new group, so there should be no negative use case.
It would take a convincing counter-argument to make me consider changing the current default behaviour. A patch making this configurable (including GUI and man pages changes too) is more likely to be accepted than a change in the default behaviour.