Merge lp://staging/~jtv/maas-test/tolerate-addressless-interface into lp://staging/maas-test

Proposed by Jeroen T. Vermeulen
Status: Merged
Approved by: Raphaël Badin
Approved revision: 95
Merged at revision: 94
Proposed branch: lp://staging/~jtv/maas-test/tolerate-addressless-interface
Merge into: lp://staging/maas-test
Diff against target: 237 lines (+98/-32)
2 files modified
maastest/detect_dhcp.py (+21/-2)
maastest/tests/test_detect_dhcp.py (+77/-30)
To merge this branch: bzr merge lp://staging/~jtv/maas-test/tolerate-addressless-interface
Reviewer Review Type Date Requested Status
Raphaël Badin (community) Approve
Review via email: mp+198693@code.staging.launchpad.net

Commit message

Continue past DHCP server check if testing network interface has no IP address.

Description of the change

I apologise for the brevity of this merge proposal. It was written in a hurry. See bug for details; the symptom of the problem is an IOError with errno = 99 (EADDRNOTAVAIL). We need to bind to that IP address, or invite problems if a dhclient is running on another interface.

On the bright side, if the interface has no IP address, that probably means that there's no DHCP server running anyway!

Jeroen

To post a comment you must log in.
Revision history for this message
Raphaël Badin (rvb) wrote :

Nice!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches