Merge lp://staging/~jtv/launchpad/bug-592762 into lp://staging/launchpad
Status: | Merged |
---|---|
Approved by: | Jeroen T. Vermeulen |
Approved revision: | no longer in the source branch. |
Merged at revision: | 11019 |
Proposed branch: | lp://staging/~jtv/launchpad/bug-592762 |
Merge into: | lp://staging/launchpad |
Diff against target: |
66 lines (+32/-1) 2 files modified
database/schema/security.cfg (+1/-0) lib/lp/translations/scripts/tests/test_translations_to_branch.py (+31/-1) |
To merge this branch: | bzr merge lp://staging/~jtv/launchpad/bug-592762 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | code | Approve | |
Review via email: mp+27390@code.staging.launchpad.net |
Commit message
TeamMembership privilege for translationstob
Description of the change
= Bug 592762 =
Sometimes the translations-
I fixed up the script to send out email notifications when this happens. But in Q/A I found that if the email recipient is a team, the email helpers need SELECT privileges for the TeamMembership table which the script currently lacks.
So here's the fix for that. As long as you don't re-build your schema first, this test reproduces the problem:
{{{
./bin/test -vv -t handleUnpushedB
}}}
Run this to make the problem go away and the test pass:
{{{
./database/
}}}
To Q/A, all I have to do is inspect the logs on staging a day after this fix is rolled out and hopefully see the script complete successfully.
Jeroen