Go Windows Azure Client Library

Merge lp://staging/~jtv/gwacl/global-libcurl-lock into lp://staging/gwacl

  1. global-libcurl-lock
  2. Merge into trunk
Proposed by Jeroen T. Vermeulen
Status: Rejected
Rejected by: Jeroen T. Vermeulen
Proposed branch: lp://staging/~jtv/gwacl/global-libcurl-lock
Merge into: lp://staging/gwacl
Diff against target: 31 lines (+13/-0)
1 file modified
x509dispatcher.go (+13/-0)
To merge this branch: bzr merge lp://staging/~jtv/gwacl/global-libcurl-lock
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) Needs Resubmitting
Review via email: mp+175229@code.staging.launchpad.net

Commit message

Fix the test failures (but not the horrible crashes) that happen when upgrading from go1.0.2 to go1.1.1.

Description of the change

There are also a bunch of segfaults that Julian is currently looking into. But the actual "failures" were caused by XML serialization no longer including a leading newline.

This fix is tedious and repetitive (really, it should quite literally be the exact same fix for all cases) but it has the advantage that it works on both Go versions, and will continue to work with other similar whitespace changes.

Jeroen

To post a comment you must log in.
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Sorry. Proposed wrong branch here.

review: Needs Resubmitting

Unmerged revisions

188. By Jeroen T. Vermeulen

Merge trunk.

187. By Jeroen T. Vermeulen

Lock-protect all use of libcurl, because it may not be reentrant.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches