Merge lp://staging/~jtv/gwacl/fix-upgrade-breakage into lp://staging/gwacl
Proposed by
Jeroen T. Vermeulen
| Status: | Merged |
|---|---|
| Approved by: | Jeroen T. Vermeulen |
| Approved revision: | 188 |
| Merged at revision: | 187 |
| Proposed branch: | lp://staging/~jtv/gwacl/fix-upgrade-breakage |
| Merge into: | lp://staging/gwacl |
| Diff against target: |
230 lines (+28/-23) 4 files modified
management_base_test.go (+4/-1) storage_base_test.go (+1/-1) storage_test.go (+3/-2) xmlobjects_test.go (+20/-19) |
| To merge this branch: | bzr merge lp://staging/~jtv/gwacl/fix-upgrade-breakage |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gavin Panella | Approve | ||
|
Review via email:
|
|||
Commit message
Fix the test failures (but not the horrible crashes) that happen when upgrading from go1.0.2 to go1.1.1.
Description of the change
There are also a bunch of segfaults that Julian is currently looking into. But the actual "failures" were caused by XML serialization no longer including a leading newline.
This fix is tedious and repetitive (really, it should quite literally be the exact same fix for all cases) but it has the advantage that it works on both Go versions, and will continue to work with other similar whitespace changes.
Jeroen
To post a comment you must log in.
Revision history for this message
| Gavin Panella (allenap) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
