Merge into trunk : import_pubkey : Code : OpenStack Compute (nova)

Merge lp://staging/~jtran/nova/import_pubkey into lp://staging/~hudson-openstack/nova/trunk

Proposed by John Tran
Status: Superseded
Proposed branch: lp://staging/~jtran/nova/import_pubkey
Merge into: lp://staging/~hudson-openstack/nova/trunk
Diff against target: 94 lines (+55/-0)
4 files modified
To merge this branch: bzr merge lp://staging/~jtran/nova/import_pubkey
Reviewer Review Type Date Requested Status
John Dewey Pending
Jesse Andrews Pending
termie Pending
Thierry Carrez ffe Pending
Devin Carlen Pending
Review via email: mp+60842@code.staging.launchpad.net

This proposal supersedes a proposal from 2011-03-23.

This proposal has been superseded by a proposal from 2011-05-16.

Description of the change

Added an EC2 API endpoint that'll allow import of public key. Prior, api only allowed generation of new keys.

To post a comment you must log in.
Revision history for this message
Devin Carlen (devcamcar) wrote : Posted in a previous version of this proposal

15 + if fingerprint:
16 + key['fingerprint'] = fingerprint

Is it useful to import a keypair with no fingerprint?

review: Needs Information
Revision history for this message
John Tran (jtran) wrote : Posted in a previous version of this proposal

In our case, we only needed the pubkeys to be injected. We didn't need the fingerprint.

Revision history for this message
Vish Ishaya (vishvananda) wrote : Posted in a previous version of this proposal

The fingerprint can be calculated pretty easily from the public key. Take the following code from crypto.py:

110 (out, err) = utils.execute('ssh-keygen', '-q', '-l', '-f',
111 '%s.pub' % (keyfile))
112 fingerprint = out.split(' ')[1]

On Mar 21, 2011, at 10:06 AM, John Tran wrote:

> In our case, we only needed the pubkeys to be injected. We didn't need the fingerprint.
> --
> https://code.launchpad.net/~jtran/nova/import_pubkey/+merge/54057
> You are subscribed to branch lp:nova.

Revision history for this message
John Dewey (retr0h) wrote : Posted in a previous version of this proposal

Be sure to add yourself to Authors and http://wiki.openstack.org/Contributors, so if approved tarmac can pull them in.

See the prerequisites section of the How to Contribute Guide:
  http://wiki.openstack.org/HowToContribute

review: Needs Fixing
Revision history for this message
John Dewey (retr0h) wrote : Posted in a previous version of this proposal

I suppose I should have marked my last review as "Needs Information".

Revision history for this message
John Tran (jtran) wrote : Posted in a previous version of this proposal

Thanks, I've updated the Authors file.

Revision history for this message
Jesse Andrews (anotherjesse) wrote : Posted in a previous version of this proposal

lgtm - we might want to move the fingerprint generation to a more central code path when we add keypair code into openstack api.

review: Approve
Revision history for this message
Thierry Carrez (ttx) wrote : Posted in a previous version of this proposal

Feature is a bit late to the party, we just hit FeatureFreeze.

If you want this into Cactus rather than wait for Diablo, could you provide a quick benefit vs. risk of regression rationale, then request a specific FFe review from me ?

Revision history for this message
Thierry Carrez (ttx) wrote : Posted in a previous version of this proposal

Linking a wishlist bug would also help.

Revision history for this message
Thierry Carrez (ttx) : Posted in a previous version of this proposal
review: Needs Information (ffe)
Revision history for this message
John Tran (jtran) wrote : Posted in a previous version of this proposal
Revision history for this message
John Tran (jtran) wrote : Posted in a previous version of this proposal

This doesn't need to be in Cactus. It can wait for Diablo.

Revision history for this message
termie (termie) wrote : Posted in a previous version of this proposal

linked to the bug, looks good to me, but I'll defer to Devin

review: Approve
Revision history for this message
Thierry Carrez (ttx) wrote : Posted in a previous version of this proposal

OK, please set it to work in progress, you can repropose it once Diablo opens (in less than 3 weeks)

Revision history for this message
Thierry Carrez (ttx) wrote : Posted in a previous version of this proposal

Merge window closed, please resubmit when Diablo opens (April 14).

review: Disapprove (ffe)
Revision history for this message
justinsb (justin-fathomdb) wrote : Posted in a previous version of this proposal

I think the EC2 call is called "ImportKeyPair", so I think this the function name should be "import_key_pair" not "import_public_key". I'm also not sure how the arguments are being mapped. Is this compatible with EC2 clients?

Revision history for this message
Thierry Carrez (ttx) wrote : Posted in a previous version of this proposal

The branch should be reproposed now that we are no longer frozen

review: Abstain (ffe)
Revision history for this message
Devin Carlen (devcamcar) wrote :

jtran - please repropose when ready.

Revision history for this message
John Tran (jtran) wrote :

> jtran - please repropose when ready.

I did that yesterday using the 'resubmit proposal' link. Was that the wrong way to do it?

Revision history for this message
Devin Carlen (devcamcar) wrote :

> > jtran - please repropose when ready.
>
> I did that yesterday using the 'resubmit proposal' link. Was that the wrong
> way to do it?

Hm, I think that should have worked. Maybe just try it again?

Unmerged revisions

Preview Diff

Failed to fetch available diffs.

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.