Merge lp://staging/~jtasker/weather-indicator/cloudy into lp://staging/weather-indicator

Proposed by Joshua Tasker
Status: Merged
Approved by: Joshua Tasker
Approved revision: 325
Merged at revision: 312
Proposed branch: lp://staging/~jtasker/weather-indicator/cloudy
Merge into: lp://staging/weather-indicator
Diff against target: 5722 lines (+2158/-964)
16 files modified
AUTHORS (+1/-0)
bin/indicator-weather (+1225/-641)
data/indicator-weather.gschema.xml (+25/-0)
data/ui/Assistant.ui (+85/-40)
data/ui/ExtendedForecast.ui (+129/-14)
data/ui/PreferencesDialog.ui (+454/-97)
debian/changelog (+35/-0)
debian/control (+26/-19)
debian/copyright (+29/-10)
debian/indicator-weather.install (+1/-0)
debian/postinst (+6/-7)
debian/rules (+10/-4)
indicator_weather/helpers.py (+9/-9)
indicator_weather/indicator_weatherconfig.py (+2/-2)
po/indicator-weather.pot (+117/-118)
setup.py (+4/-3)
To merge this branch: bzr merge lp://staging/~jtasker/weather-indicator/cloudy
Reviewer Review Type Date Requested Status
Vadim Rutkovsky Approve
Review via email: mp+164598@code.staging.launchpad.net

Description of the change

This fixes all the "SIGSEGV" bugs related to glib/dbus; (libdbus is not thread-safe - I re-wrote some of the threading code to deal with this)
I also updated it to use Gtk3 and GObject, instead of the now-deprecated PyGtk.
Finally, I added code to calculate humidex/wind chill, and added a related tab to the Preferences Dialog.

Note that this version requires pywapi 0.3.1, which is available here:
http://code.google.com/p/python-weather-api/downloads/detail?name=pywapi-0.3.1.tar.gz

deb packages for pywapi 0.3.1 are available here:
https://launchpad.net/~pywapi-devel

From the changelog:
  * Ported to GTK3 and GObject from PyGTK
  * Rewrite threading code to avoid dbus-related crashes (LP: #743541)
  * Added "feels like" temperature (humidex/heat index/wind chill)
  * New "Conditions" tab in Preferences dialog to choose temperature
    formulas and toggle display of some condition information
  * Bumped version number to reflect massive changes

Note that it still sometimes gives LIBDBUSMENU-GLIB warnings to .xsession-errors, but they can be safely ignored - I have left it running for a week straight with no crashes.

To post a comment you must log in.
Revision history for this message
Joshua Tasker (jtasker) wrote :

The dbus-related bug I am talking about is this one: https://bugs.launchpad.net/ubuntu/+source/indicator-weather/+bug/743541

Revision history for this message
Vadim Rutkovsky (roignac) wrote :

Great, thanks!

Unfortunately, I can't test the changes, but it seems that you've tested them pretty good

review: Approve
320. By Joshua Tasker

  * Missing comma in debian/control file

321. By Joshua Tasker

Update changelog

322. By Joshua Tasker

Fix 4-day forecast display (LP: #1182324)
'OK' button in Preferences Dialog is now more responsive

323. By Joshua Tasker

update changelog

324. By Joshua Tasker

Prepare for release

325. By Joshua Tasker

typo in debian/control

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: