testresources

Merge lp://staging/~jseutter/testresources/py3_without_distribute into lp://staging/~testresources-developers/testresources/trunk

  1. py3_without_distribute
  2. Merge into trunk
Proposed by Jerry Seutter
Status: Needs review
Proposed branch: lp://staging/~jseutter/testresources/py3_without_distribute
Merge into: lp://staging/~testresources-developers/testresources/trunk
Diff against target: 193 lines (+29/-20)
6 files modified
lib/testresources/__init__.py (+13/-12)
lib/testresources/tests/TestUtil.py (+2/-1)
lib/testresources/tests/test_resource_graph.py (+2/-2)
lib/testresources/tests/test_resourced_test_case.py (+2/-2)
lib/testresources/tests/test_test_resource.py (+1/-1)
setup.py (+9/-2)
To merge this branch: bzr merge lp://staging/~jseutter/testresources/py3_without_distribute
Reviewer Review Type Date Requested Status
Barry Warsaw (community) Approve
testresources developers Pending
Review via email: mp+105568@code.staging.launchpad.net

Description of the change

This MP is like the previous py 3 MP, but without the addition of distribute_setup. It adds support for Python 3.

See the original MP if more information is needed: https://code.launchpad.net/~jseutter/testresources/py3/+merge/105525

To post a comment you must log in.
Revision history for this message
Barry Warsaw (barry) wrote :

This looks pretty good to me. Unfortunately the test suite has a hidden dependency on fixtures, so that needs to get ported too. :(

% python test_all.py
Traceback (most recent call last):
  File "test_all.py", line 127, in <module>
    sys.exit(main(sys.argv))
  File "test_all.py", line 119, in main
    test_suite().visit(visitor)
  File "test_all.py", line 82, in test_suite
    result.addTest(testresources.test_suite())
  File "/tmp/tr/lib/python3.2/site-packages/testresources-0.2.5-py3.2.egg/testresources/__init__.py", line 29, in test_suite
    return testresources.tests.test_suite()
  File "/tmp/tr/lib/python3.2/site-packages/testresources-0.2.5-py3.2.egg/testresources/tests/__init__.py", line 27, in test_suite
    import testresources.tests.test_test_resource
  File "/tmp/tr/lib/python3.2/site-packages/testresources-0.2.5-py3.2.egg/testresources/tests/test_test_resource.py", line 18, in <module>
    from fixtures.tests.helpers import LoggingFixture
ImportError: No module named fixtures.tests.helpers

review: Approve
Reply
Revision history for this message
Jerry Seutter (jseutter) wrote :

> This looks pretty good to me. Unfortunately the test suite has a hidden
> dependency on fixtures, so that needs to get ported too. :(

Oh right, I'll upload a patch for that fairly quickly..

Reply

Unmerged revisions

61. By Jerry Seutter

Adding support for Python 3.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches