Merge lp://staging/~jseutter/testresources/py3 into lp://staging/~testresources-developers/testresources/trunk

Proposed by Jerry Seutter
Status: Needs review
Proposed branch: lp://staging/~jseutter/testresources/py3
Merge into: lp://staging/~testresources-developers/testresources/trunk
Diff against target: 695 lines (+526/-20)
7 files modified
distribute_setup.py (+494/-0)
lib/testresources/__init__.py (+13/-12)
lib/testresources/tests/TestUtil.py (+2/-1)
lib/testresources/tests/test_resource_graph.py (+2/-2)
lib/testresources/tests/test_resourced_test_case.py (+2/-2)
lib/testresources/tests/test_test_resource.py (+1/-1)
setup.py (+12/-2)
To merge this branch: bzr merge lp://staging/~jseutter/testresources/py3
Reviewer Review Type Date Requested Status
Jerry Seutter (community) Disapprove
Barry Warsaw Pending
testresources developers Pending
Review via email: mp+105525@code.staging.launchpad.net

Description of the change

This branch adds support for python 3. It uses "from __future__ import print_function", so it will not work in Python versions older than Python 2.6.

To post a comment you must log in.
Revision history for this message
Robert Collins (lifeless) wrote :

This seems to be much more than py3; whats the additional stuff for?
[and why would it be in-tree, it looks boilerplatey].

-Rob

Revision history for this message
Barry Warsaw (barry) wrote :

On May 11, 2012, at 08:49 PM, Robert Collins wrote:

>This seems to be much more than py3; whats the additional stuff for?
>[and why would it be in-tree, it looks boilerplatey].

Are you referring to the distribute_setup.py file? IME, distribute is much
better at Python 3 compatibility and is future-proof for when distutils is
removed[*], so I recommended Jerry switch to it rather than use it or
ez_setup.

[*] and not a moment too soon.

Revision history for this message
Barry Warsaw (barry) wrote :

On May 11, 2012, at 08:01 PM, Jerry Seutter wrote:

>You have been requested to review the proposed merge of
>lp:~jseutter/testresources/py3 into lp:testresources.
>
>For more details, see:
>https://code.launchpad.net/~jseutter/testresources/py3/+merge/105525
>
>This branch adds support for python 3. It uses "from __future__ import
>print_function", so it will not work in Python versions older than Python
>2.6.

+1

Revision history for this message
Robert Collins (lifeless) wrote :

I have a philospohical objection to having such massive boilerplate in
source trees. I'd put a smiley face here, but I'm not being humourous
;) It has to be maintained and updated - its dead weight.

Revision history for this message
Barry Warsaw (barry) wrote :

On May 11, 2012, at 11:40 PM, Robert Collins wrote:

>I have a philospohical objection to having such massive boilerplate in
>source trees. I'd put a smiley face here, but I'm not being humourous
>;) It has to be maintained and updated - its dead weight.

If the package is already pulling in ez_setup.py then it should definitely
convert to using distribute_setup.py. If it isn't doing the former, then just
change it back to using distutils.

Revision history for this message
Robert Collins (lifeless) wrote :

On Sat, May 12, 2012 at 2:14 PM, Barry Warsaw <email address hidden> wrote:
> On May 11, 2012, at 11:40 PM, Robert Collins wrote:
>
>>I have a philospohical objection to having such massive boilerplate in
>>source trees. I'd put a smiley face here, but I'm not being humourous
>>;) It has to be maintained and updated - its dead weight.
>
> If the package is already pulling in ez_setup.py then it should definitely
> convert to using distribute_setup.py.  If it isn't doing the former, then just
> change it back to using distutils.

Its not; ez_setup.py is terrible too :)

I'll look at this tomorrow/monday and merge just the py3 bits.

-Rob

Revision history for this message
Jerry Seutter (jseutter) wrote :

I made a new merge proposal that does not include distribute_setup. See https://code.launchpad.net/~jseutter/testresources/py3_without_distribute/+merge/105568 .

review: Disapprove

Unmerged revisions

61. By Jerry Seutter

Adding python 3 support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches